Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: lib/components/carousel.dart

Issue 14295009: Fix widget.dart to work with the latest web_ui library. Specifically, query selectors need to use "… (Closed) Base URL: https://github.com/kevmoo/widget.dart.git@master
Patch Set: PTAL Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/components/carousel.dart
diff --git a/lib/components/carousel.dart b/lib/components/carousel.dart
index c07a12b0595d19a796f4266f2bb7955705c2a396..c4cff4629110e7efb4f673a0ff868e86001f7aa3 100644
--- a/lib/components/carousel.dart
+++ b/lib/components/carousel.dart
@@ -25,13 +25,13 @@ class Carousel extends WebComponent {
Future<bool> previous() => _moveDelta(false);
- SwapComponent get _swap => this.query('x-carousel > .carousel > x-swap').xtag;
+ SwapComponent get _swap => this.query('[is=x-carousel] > .carousel > [is=x-swap]').xtag;
Siggi Cherem (dart-lang) 2013/04/16 17:34:36 long line
Jacob 2013/04/16 17:45:46 Done.
Future<bool> _moveDelta(bool doNext) {
final swap = _swap;
assert(swap != null);
if(swap.items.length == 0) {
- return new Future.immediate(false);
+ return new Future.value(false);
}
assert(doNext != null);

Powered by Google App Engine
This is Rietveld 408576698