Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: lib/components/accordion.dart

Issue 14295009: Fix widget.dart to work with the latest web_ui library. Specifically, query selectors need to use "… (Closed) Base URL: https://github.com/kevmoo/widget.dart.git@master
Patch Set: PTAL Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/components/accordion.dart
diff --git a/lib/components/accordion.dart b/lib/components/accordion.dart
index d82192aa41f4e2439635e06e7f200c59db9d89fc..5a68b8202af32d8459e3e032ae2f4c4c0985441a 100644
--- a/lib/components/accordion.dart
+++ b/lib/components/accordion.dart
@@ -26,15 +26,12 @@ class Accordion extends WebComponent {
});
}
- List<Element> _getAllCollapseElements() => this.queryAll('x-accordion > x-collapse');
+ List<Element> _getAllCollapseElements() => this.queryAll('[is=x-accordion] > [is=x-collapse]');
Siggi Cherem (dart-lang) 2013/04/16 17:34:36 long line (the original code was already like that
Jacob 2013/04/16 17:45:46 Done.
Jacob 2013/04/16 17:45:46 Done.
void _onOpen(Event openEvent) {
- if(openEvent.target is UnknownElement) {
- final UnknownElement target = openEvent.target;
- final ShowHideComponent shc = target.xtag as ShowHideComponent;
- if(shc != null) {
- _onShowHideToggle(shc);
- }
+ Element target = openEvent.target;
+ if(target.xtag is ShowHideComponent) {
Siggi Cherem (dart-lang) 2013/04/16 17:34:36 style nit: space after 'if' (although seems like t
Jacob 2013/04/16 17:45:46 Fixed. When we touch a file we should make it mor
+ _onShowHideToggle(target.xtag);
}
}

Powered by Google App Engine
This is Rietveld 408576698