Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: lib/components/swap.dart

Issue 14295009: Fix widget.dart to work with the latest web_ui library. Specifically, query selectors need to use "… (Closed) Base URL: https://github.com/kevmoo/widget.dart.git@master
Patch Set: ptal Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/components/modal.html ('k') | lib/components/swap.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/components/swap.dart
diff --git a/lib/components/swap.dart b/lib/components/swap.dart
index c652034c55dad3a89c12bb49c811fdb51974c620..6a03c0bd4d0091a502ea43efed0995caf2f09dc9 100644
--- a/lib/components/swap.dart
+++ b/lib/components/swap.dart
@@ -51,7 +51,7 @@ class Swap extends WebComponent implements SwapComponent {
final oldActiveChild = activeItem;
if(oldActiveChild == item) {
- return new Future<bool>.immediate(true);
+ return new Future<bool>.value(true);
}
[oldActiveChild, item].forEach((e) => e.classes.remove(_dirClassPrev));
@@ -84,7 +84,7 @@ class Swap extends WebComponent implements SwapComponent {
void _initialize() {
if(_contentElementField == null) {
- _contentElementField = this.query('x-swap > .content');
+ _contentElementField = this.query('[is=x-swap] > .content');
if(_contentElementField == null) {
throw 'Could not find the content element. Either the template has changed or state was accessed too early in the component lifecycle.';
}
« no previous file with comments | « lib/components/modal.html ('k') | lib/components/swap.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698