Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 14295006: Don't copy iossim after compilation. (Closed)

Created:
7 years, 8 months ago by lliabraa
Modified:
7 years, 8 months ago
Reviewers:
stuartmorgan, qsr
CC:
chromium-reviews
Visibility:
Public.

Description

Don't copy iossim after compilation. The scripts that were relying on the post-copy location are being updated to use the pre-copy location. BUG=228157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195228

Patch Set 1 #

Patch Set 2 : don't remove variables because the gypi uses them. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M testing/iossim/iossim.gyp View 1 2 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lliabraa
@reviewers - whoever gets to it first n.b. the following CL must be committed first: ...
7 years, 8 months ago (2013-04-16 13:09:34 UTC) #1
stuartmorgan
LGTM
7 years, 8 months ago (2013-04-16 13:17:13 UTC) #2
stuartmorgan
SLGTM
7 years, 8 months ago (2013-04-19 14:23:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/14295006/5001
7 years, 8 months ago (2013-04-19 14:38:10 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 17:50:59 UTC) #5
Message was sent while issue was closed.
Change committed as 195228

Powered by Google App Engine
This is Rietveld 408576698