Re-enable a few find in page tests.

Re-enable a few find in page tests.

They had been disabled -- not due to inherent flakiness in the test itself, but due to an environment issue (bug 96594) which affects a good number of tests. I'm following the precedent of others by re-enabling these tests while we work on a solution for the underlying environment issue. Note: We've already had a regression due to the tests being disabled.

TBR=sky
BUG=145476, 128724, 152100, 177487
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195201

[Finnur, 2013-04-18 14:49:10]

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
File chrome/browser/ui/views/find_bar_view.cc (right):

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
chrome/browser/ui/views/find_bar_view.cc:195: SetFindText(find_text);
This is really just so that we have a single chokepoint function for setting the
text (easier debugging).

[msw, 2013-04-18 16:11:57]

LGTM, since it's good to try re-enabling flaky test now and then, but:

1) The issue http://crbug.com/96594 isn't totally fixed, so expect more flakes.
Please alert sheriffs and the channel about landing this.

2) A couple bugs don't look related, they may still independently cause flakes.
Please put all the bugs from deleted comments in BUG= (and take/close them?).

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
File chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (left):

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:68: // Fails often
on Win, CrOS. http://crbug.com/145476, http://crbug.com/128724
http://crbug.com/145476 looks related, but I'm not sure that
http://crbug.com/128724 is related, no one posted copies of the failure logs...

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:220: // Flaky on XP:
http://crbug.com/152100
http://crbug.com/152100 doesn't look related.

[Finnur, 2013-04-19 10:55:45]

> 1) The issue http://crbug.com/96594 isn't totally fixed, so expect more
flakes.
> Please alert sheriffs and the channel about landing this.

Will do.

TBR=sky (for Views).

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
File chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (left):

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:68: // Fails often
on Win, CrOS. http://crbug.com/145476, http://crbug.com/128724
Yeah, it is hard to say. There was a suspected CL mentioned and a followup CL
that, if I recall, fixed the problem(s) and re-enabled some of the tests. Since
there's no debug info we might as well enable this and see what happens.

https://codereview.chromium.org/14295003/diff/23001/chrome/browser/ui/views/f...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:220: // Flaky on XP:
http://crbug.com/152100
On 2013/04/18 16:11:57, msw wrote:
> http://crbug.com/152100 doesn't look related.

Remember when you said you couldn't repro the flakiness on your box? Well, I
could repro it consistently (it wasn't even flakiness, it was a consistent
failure). But when I matched what you did (reinstating reverted SearchTextfield
class), I stopped being able to repro.

[commit-bot: I haz the power, 2013-04-19 11:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/finnur@chromium.org/14295003/31001

[commit-bot: I haz the power, 2013-04-19 15:07:46]

Change committed as 195201