Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1429333002: Deprecate STORAGE_EXPORT_PRIVATE macro. (Closed)

Created:
5 years, 1 month ago by xhwang
Modified:
5 years, 1 month ago
Reviewers:
kinuko
CC:
chromium-reviews, nhiroki, kinuko+fileapi, dcheng, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate STORAGE_EXPORT_PRIVATE macro. Replace STORAGE_EXPORT_PRIVATE with STORAGE_EXPORT since they are the same. BUG=552248 Committed: https://crrev.com/89a6a3da5de6e63735b1b54589c2f37a8e5fda9c Cr-Commit-Position: refs/heads/master@{#358354}

Patch Set 1 #

Patch Set 2 : rebase only #

Patch Set 3 : fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -46 lines) Patch
M storage/browser/database/database_quota_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/database/databases_table.h View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_context.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_usage_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_writer_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/native_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_origin_database_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/transient_file_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/quota/quota_database.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M storage/browser/quota/quota_temporary_storage_evictor.h View 1 chunk +1 line, -2 lines 0 comments Download
M storage/browser/quota/storage_monitor.h View 5 chunks +5 lines, -5 lines 0 comments Download
M storage/browser/storage_browser_export.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xhwang
PTAL
5 years, 1 month ago (2015-11-06 07:01:18 UTC) #2
xhwang
rebase only
5 years, 1 month ago (2015-11-06 07:23:29 UTC) #3
kinuko
lgtm once you address the bot failures.
5 years, 1 month ago (2015-11-06 08:21:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429333002/40001
5 years, 1 month ago (2015-11-06 17:33:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 18:24:29 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 18:25:32 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89a6a3da5de6e63735b1b54589c2f37a8e5fda9c
Cr-Commit-Position: refs/heads/master@{#358354}

Powered by Google App Engine
This is Rietveld 408576698