Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1429303005: Add fast Smi op version of switchable instance calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index 42b3677bc82c3adf48a372fd084373708321f716..05ac0dedb49799bcdeaec328a280a02f7e9a9b5a 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1325,17 +1325,29 @@ void FlowGraphCompiler::EmitSwitchableInstanceCall(
__ CallPatchable(*StubCode::ICLookup_entry());
} else {
const String& name = String::Handle(zone(), ic_data.target_name());
- const Array& arguments_descriptor =
- Array::ZoneHandle(zone(), ic_data.arguments_descriptor());
- ASSERT(!arguments_descriptor.IsNull() &&
- (arguments_descriptor.Length() > 0));
- const MegamorphicCache& cache = MegamorphicCache::ZoneHandle(zone(),
- MegamorphicCacheTable::Lookup(isolate(), name, arguments_descriptor));
-
- __ LoadUniqueObject(RBX, cache);
- __ CallPatchable(*StubCode::MegamorphicLookup_entry());
+
+ if (name.raw() == Symbols::Plus().raw()) {
+ __ LoadUniqueObject(RBX, ic_data);
+ __ CallPatchable(*StubCode::ICSmiAddLookup_entry());
+ } else if (name.raw() == Symbols::Minus().raw()) {
+ __ LoadUniqueObject(RBX, ic_data);
+ __ CallPatchable(*StubCode::ICSmiSubLookup_entry());
+ } else if (name.raw() == Symbols::Equals().raw()) {
+ __ LoadUniqueObject(RBX, ic_data);
+ __ CallPatchable(*StubCode::ICSmiEqualLookup_entry());
+ } else {
+ const Array& arguments_descriptor =
+ Array::ZoneHandle(zone(), ic_data.arguments_descriptor());
+ ASSERT(!arguments_descriptor.IsNull() &&
+ (arguments_descriptor.Length() > 0));
+ const MegamorphicCache& cache = MegamorphicCache::ZoneHandle(zone(),
+ MegamorphicCacheTable::Lookup(isolate(), name, arguments_descriptor));
+
+ __ LoadUniqueObject(RBX, cache);
+ __ CallPatchable(*StubCode::MegamorphicLookup_entry());
+ }
}
- __ call(RCX);
+ __ call(RCX); // A fast Smi operation may return past this call.
AddCurrentDescriptor(RawPcDescriptors::kOther,
Thread::kNoDeoptId, token_pos);
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698