Add fast Smi op version of switchable instance calls.

runtime/vm/stub_code_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 2070 matching lines @@
   const Register left = RAX;
   const Register right = RDX;
 
   __ movq(left, Address(RSP, 2 * kWordSize));
   __ movq(right, Address(RSP, 1 * kWordSize));
   GenerateIdenticalWithNumberCheckStub(assembler, left, right);
   __ ret();
 }
 
 
+// Called from megamorphic calls.
+//  RDI: receiver
+//  RBX: MegamorphicCache (preserved)
+// Result:
+//  RCX: target entry point
+//  CODE_REG: target Code
+//  R10: arguments descriptor
 void StubCode::EmitMegamorphicLookup(Assembler* assembler) {
   __ LoadTaggedClassIdMayBeSmi(RAX, RDI);
   // RAX: class ID of the receiver (smi).
   __ movq(R10,
           FieldAddress(RBX, MegamorphicCache::arguments_descriptor_offset()));
   __ movq(RDI, FieldAddress(RBX, MegamorphicCache::buckets_offset()));
   __ movq(R9, FieldAddress(RBX, MegamorphicCache::mask_offset()));
   // RDI: cache buckets array.
   // RBX: mask.
   __ movq(RCX, RAX);
@@ skipping 19 matching lines @@
   // Call the target found in the cache.  For a class id match, this is a
   // proper target for the given name and arguments descriptor.  If the
   // illegal class id was found, the target is a cache miss handler that can
   // be invoked as a normal Dart function.
   __ movq(RAX, FieldAddress(RDI, RCX, TIMES_8, base + kWordSize));
   __ movq(RCX, FieldAddress(RAX, Function::entry_point_offset()));
   __ movq(CODE_REG, FieldAddress(RAX, Function::code_offset()));
 }
 
 
-// Called from megamorphic calls.
-//  RDI: receiver
-//  RBX: MegamorphicCache (preserved)
-// Result:
-//  RCX: target entry point
-//  CODE_REG: target Code
-//  R10: arguments descriptor
 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) {
   EmitMegamorphicLookup(assembler);
   __ ret();
 }
 
 
 // Called from switchable IC calls.
 //  RDI: receiver
 //  RBX: ICData (preserved)
 // Result:
 //  RCX: target entry point
 //  CODE_REG: target Code object
 //  R10: arguments descriptor
-void StubCode::GenerateICLookupStub(Assembler* assembler) {
+static void EmitICLookup(Assembler* assembler,
+                         intptr_t args_checked,
+                         Token::Kind kind) {
+  if (kind != Token::kILLEGAL) {
+    __ Comment("Fast Smi op");
+    Label not_smi_or_overflow;
+
+    // RDI: Receiver
+    __ movq(RCX, Address(RSP, + 1 * kWordSize));
+    // RCX: Argument
+    __ movq(R13, RCX);
+    __ orq(R13, RDI);
+    __ testq(R13, Immediate(kSmiTagMask));
+    __ j(NOT_ZERO, &not_smi_or_overflow);
+    __ movq(RAX, RDI);
+    switch (kind) {
+      case Token::kADD: {
+        __ addq(RAX, RCX);
+        __ j(OVERFLOW, &not_smi_or_overflow);
+        break;
+      }
+      case Token::kSUB: {
+        __ subq(RAX, RCX);
+        __ j(OVERFLOW, &not_smi_or_overflow);
+        break;
+      }
+      case Token::kEQ: {
+        Label done, is_true;
+        __ cmpq(RAX, RCX);
+        __ j(EQUAL, &is_true, Assembler::kNearJump);
+        __ LoadObject(RAX, Bool::False());
+        __ jmp(&done, Assembler::kNearJump);
+        __ Bind(&is_true);
+        __ LoadObject(RAX, Bool::True());
+        __ Bind(&done);
+        break;
+      }
+      default: UNIMPLEMENTED();
+    }
+    // Return past the call to lookup result.
+    intptr_t call_length = 2;  // call rcx
+    __ AddImmediate(Address(RSP, 0), Immediate(call_length));
+    __ ret();
+
+    __ Bind(&not_smi_or_overflow);
+  }
+
   Label loop, found, miss;
 
   __ movq(R13, FieldAddress(RBX, ICData::ic_data_offset()));
   __ movq(R10, FieldAddress(RBX, ICData::arguments_descriptor_offset()));
   __ leaq(R13, FieldAddress(R13, Array::data_offset()));
   // R13: first IC entry
   __ LoadTaggedClassIdMayBeSmi(RAX, RDI);
   // RAX: receiver cid as Smi
 
   __ Bind(&loop);
   __ movq(R9, Address(R13, 0));
   __ cmpq(RAX, R9);
   __ j(EQUAL, &found, Assembler::kNearJump);
 
   ASSERT(Smi::RawValue(kIllegalCid) == 0);
   __ testq(R9, R9);
   __ j(ZERO, &miss, Assembler::kNearJump);
 
-  const intptr_t entry_length = ICData::TestEntryLengthFor(1) * kWordSize;
+  const intptr_t entry_length =
+      ICData::TestEntryLengthFor(args_checked) * kWordSize;
   __ addq(R13, Immediate(entry_length));  // Next entry.
   __ jmp(&loop);
 
   __ Bind(&found);
-  const intptr_t target_offset = ICData::TargetIndexFor(1) * kWordSize;
+  const intptr_t target_offset =
+      ICData::TargetIndexFor(args_checked) * kWordSize;
   __ movq(RAX, Address(R13, target_offset));
   __ movq(RCX, FieldAddress(RAX, Function::entry_point_offset()));
   __ movq(CODE_REG, FieldAddress(RAX, Function::code_offset()));
   __ ret();
 
   __ Bind(&miss);
   __ LoadIsolate(RAX);
   __ movq(CODE_REG, Address(RAX, Isolate::ic_miss_code_offset()));
   __ movq(RCX, FieldAddress(CODE_REG, Code::entry_point_offset()));
   __ ret();
 }
 
+
+void StubCode::GenerateICLookupStub(Assembler* assembler) {
+  EmitICLookup(assembler, 1, Token::kILLEGAL);
+}
+
+
+void StubCode::GenerateICSmiAddLookupStub(Assembler* assembler) {
+  EmitICLookup(assembler, 2, Token::kADD);
+}
+
+
+void StubCode::GenerateICSmiSubLookupStub(Assembler* assembler) {
+  EmitICLookup(assembler, 2, Token::kSUB);
+}
+
+
+void StubCode::GenerateICSmiEqualLookupStub(Assembler* assembler) {
+  EmitICLookup(assembler, 2, Token::kEQ);
+}
+
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64