chrome/installer/setup/install.cc - Issue 14287008: Refactoring installer shortcut deletion; adding dedicated shortcut update feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 14287008: Refactoring installer shortcut deletion; adding dedicated shortcut update feature. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync; fixing .git/config to allow CQ to commit. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index f64ed8e4820ca1b5243f5ded5b4c467e579c8ecb..b8ebe94fd372897dac60815ae6fae078910fd018 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -260,9 +260,9 @@ void CleanupLegacyShortcuts(const InstallerState& installer_state,

file_util::Delete(uninstall_shortcut_path, false);

if (installer_state.system_install()) {

- ShellUtil::RemoveShortcut(

- ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH, dist, chrome_exe,

- ShellUtil::SYSTEM_LEVEL, NULL);

+ ShellUtil::RemoveShortcuts(

+ ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH, dist,

+ ShellUtil::SYSTEM_LEVEL, chrome_exe);

}

« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')