Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14286004: Make touch drag drop and touch editing flags tri-state and turn them on by (Closed)

Created:
7 years, 8 months ago by varunjain
Modified:
7 years, 8 months ago
Reviewers:
Avi (use Gerrit), jam, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Make touch drag drop and touch editing flags tri-state and turn them on by default on chromeos. BUG=115237, 168162 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196446

Patch Set 1 #

Total comments: 6

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -27 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
A ui/base/ui_base_switches_util.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
A ui/base/ui_base_switches_util.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/views/view.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
varunjain
jam@ for content/ sky@ for rest
7 years, 8 months ago (2013-04-24 06:01:06 UTC) #1
sky
LGTM https://codereview.chromium.org/14286004/diff/1/chrome/browser/chromeos/login/chrome_restart_request.cc File chrome/browser/chromeos/login/chrome_restart_request.cc (right): https://codereview.chromium.org/14286004/diff/1/chrome/browser/chromeos/login/chrome_restart_request.cc#newcode95 chrome/browser/chromeos/login/chrome_restart_request.cc:95: ::switches::kDisableTouchDragDrop, Keep these sorted. https://codereview.chromium.org/14286004/diff/1/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): ...
7 years, 8 months ago (2013-04-24 14:44:22 UTC) #2
varunjain
https://codereview.chromium.org/14286004/diff/1/chrome/browser/chromeos/login/chrome_restart_request.cc File chrome/browser/chromeos/login/chrome_restart_request.cc (right): https://codereview.chromium.org/14286004/diff/1/chrome/browser/chromeos/login/chrome_restart_request.cc#newcode95 chrome/browser/chromeos/login/chrome_restart_request.cc:95: ::switches::kDisableTouchDragDrop, On 2013/04/24 14:44:23, sky wrote: > Keep these ...
7 years, 8 months ago (2013-04-24 18:09:25 UTC) #3
Avi (use Gerrit)
lgtm
7 years, 8 months ago (2013-04-24 18:26:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/14286004/8001
7 years, 8 months ago (2013-04-24 18:27:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=106514
7 years, 8 months ago (2013-04-24 20:23:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/14286004/8001
7 years, 8 months ago (2013-04-25 17:50:02 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 18:37:29 UTC) #8
Message was sent while issue was closed. 
Change committed as 196446

Powered by Google App Engine
This is Rietveld 408576698