Pass InterpolationEnvironment as a reference to InterpolationType conversion functions

Pass InterpolationEnvironment as a reference to InterpolationType conversion functions

This change converts the InterpolationEnvironment* parameter of
InterpolationType::maybeConvertPairwise() and InterpolationType::maybeConvertSingle()
into an InterpolationEnvironment&.
Previously we would attempt conversion of the keyframes without an environment
until crrev.com/70ab3999 which removed the optimisation.

This patch is to improve code health in the absence of this optimisation
with the reasoning that we can add the optimisation back given performance
data to justify the complexity cost.

Committed: https://crrev.com/11fb42276c0ceff1f5e0ac9c3ff20b726692c8e0
Cr-Commit-Position: refs/heads/master@{#356769}

[alancutter (OOO until 2018), 2015-10-27 02:44:31]

Description was changed from

==========
Pass InterpolationEnvironment as a reference to InterpolationType conversion
functions
==========

to

==========
Pass InterpolationEnvironment as a reference to InterpolationType conversion
functions

This change converts the InterpolationEnvironment* parameter of
InterpolationType::maybeConvertPairwise() and
InterpolationType::maybeConvertSingle()
into an InterpolationEnvironment&.
Previously we would attempt conversion of the keyframes without an environment
until crrev.com/70ab3999 which removed the optimisation.

This patch is to improve code health in the absence of this optimisation
with the reasoning that we can add the optimisation back given performance
data to justify the complexity cost.
==========

[alancutter (OOO until 2018), 2015-10-27 02:44:32]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2015-10-27 06:59:20]

lgtm

[alancutter (OOO until 2018), 2015-10-28 00:13:12]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 00:14:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428513003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1

[commit-bot: I haz the power, 2015-10-28 00:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 00:18:04]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2015-10-28 12:41:40]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2015-10-28 12:41:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428513003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1

[commit-bot: I haz the power, 2015-10-28 12:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 12:44:45]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[alancutter (OOO until 2018), 2015-10-29 04:08:53]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2015-10-29 04:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428513003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428513003/1

[commit-bot: I haz the power, 2015-10-29 05:11:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-29 05:11:45]

Patchset 1 (id:??) landed as
https://crrev.com/11fb42276c0ceff1f5e0ac9c3ff20b726692c8e0
Cr-Commit-Position: refs/heads/master@{#356769}