unittest/AssemblerX8664/ControlFlow.cpp - Issue 1428443002: Enhance address mode recovery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8664/ControlFlow.cpp

Issue 1428443002: Enhance address mode recovery (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Streamline absolute addressing support (rip-relative on x64) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: unittest/AssemblerX8664/ControlFlow.cpp

diff --git a/unittest/AssemblerX8664/ControlFlow.cpp b/unittest/AssemblerX8664/ControlFlow.cpp

index 704f6fdb7d1fea6c7410c7eef5c77038d603f46e..30a0a5233edf0397a69a4c2c45d7ff986e0aaa9a 100644

--- a/unittest/AssemblerX8664/ControlFlow.cpp

+++ b/unittest/AssemblerX8664/ControlFlow.cpp

@@ -158,6 +158,7 @@ TEST_F(AssemblerX8664Test, CallReg) {

TEST_F(AssemblerX8664Test, CallAddr) {

#define TestImpl(Dst, Src) \

do { \

+ static constexpr AssemblerFixup *Fixup = nullptr; \

const uint32_t T0 = allocateQword(); \

const uint64_t V0 = 0xA0C0FFEEBEEFFEEFull; \

__ call(Immediate(16)); \

@@ -169,7 +170,7 @@ TEST_F(AssemblerX8664Test, CallAddr) {

} \

__ mov(IceType_i64, Encoded_GPR_##Dst##q(), dwordAddress(T0)); \

__ mov(IceType_i64, Encoded_GPR_##Src##q(), Encoded_GPR_rsp()); \

- __ call(Address(Encoded_GPR_##Src##q(), 0)); \

+ __ call(Address(Encoded_GPR_##Src##q(), 0, Fixup)); \

__ popl(Encoded_GPR_##Src##q()); \

AssembledTest test = assemble(); \