Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: unittest/AssemblerX8632/X87.cpp

Issue 1428443002: Enhance address mode recovery (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Streamline absolute addressing support (rip-relative on x64) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: unittest/AssemblerX8632/X87.cpp
diff --git a/unittest/AssemblerX8632/X87.cpp b/unittest/AssemblerX8632/X87.cpp
index d3f38a16c19907593b2f3fdd3d3a48a01b34436b..b5faf87bd42241f6701283fe1f9e138212010977 100644
--- a/unittest/AssemblerX8632/X87.cpp
+++ b/unittest/AssemblerX8632/X87.cpp
@@ -14,8 +14,9 @@ namespace Test {
namespace {
TEST_F(AssemblerX8632LowLevelTest, Fld) {
- __ fld(IceType_f32, Address(GPRRegister::Encoded_Reg_ebp, 1));
- __ fld(IceType_f64, Address(GPRRegister::Encoded_Reg_ebp, 0x10000));
+ static constexpr AssemblerFixup *Fixup = nullptr;
+ __ fld(IceType_f32, Address(GPRRegister::Encoded_Reg_ebp, 1, Fixup));
+ __ fld(IceType_f64, Address(GPRRegister::Encoded_Reg_ebp, 0x10000, Fixup));
constexpr size_t ByteCount = 9;
ASSERT_EQ(ByteCount, codeBytesSize());
@@ -31,8 +32,9 @@ TEST_F(AssemblerX8632LowLevelTest, Fld) {
}
TEST_F(AssemblerX8632LowLevelTest, FstpAddr) {
- __ fstp(IceType_f32, Address(GPRRegister::Encoded_Reg_ebp, 1));
- __ fstp(IceType_f64, Address(GPRRegister::Encoded_Reg_ebp, 0x10000));
+ static constexpr AssemblerFixup *Fixup = nullptr;
+ __ fstp(IceType_f32, Address(GPRRegister::Encoded_Reg_ebp, 1, Fixup));
+ __ fstp(IceType_f64, Address(GPRRegister::Encoded_Reg_ebp, 0x10000, Fixup));
constexpr size_t ByteCount = 9;
ASSERT_EQ(ByteCount, codeBytesSize());
@@ -57,7 +59,8 @@ TEST_F(AssemblerX8632LowLevelTest, Fincstp) {
}
TEST_F(AssemblerX8632LowLevelTest, FnstcwAddr) {
- __ fnstcw(Address(GPRRegister::Encoded_Reg_ebp, 0x12345));
+ static constexpr AssemblerFixup *Fixup = nullptr;
+ __ fnstcw(Address(GPRRegister::Encoded_Reg_ebp, 0x12345, Fixup));
constexpr size_t ByteCount = 6;
ASSERT_EQ(ByteCount, codeBytesSize());
@@ -69,7 +72,8 @@ TEST_F(AssemblerX8632LowLevelTest, FnstcwAddr) {
}
TEST_F(AssemblerX8632LowLevelTest, FldcwAddr) {
- __ fldcw(Address(GPRRegister::Encoded_Reg_ebp, 0x12345));
+ static constexpr AssemblerFixup *Fixup = nullptr;
+ __ fldcw(Address(GPRRegister::Encoded_Reg_ebp, 0x12345, Fixup));
constexpr size_t ByteCount = 6;
ASSERT_EQ(ByteCount, codeBytesSize());

Powered by Google App Engine
This is Rietveld 408576698