src/IceInstX86BaseImpl.h - Issue 1428443002: Enhance address mode recovery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86BaseImpl.h

Issue 1428443002: Enhance address mode recovery (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Streamline absolute addressing support (rip-relative on x64) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstX86BaseImpl.h

diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h

index 056ecfe4ff2263484106f3766561e7b0c8cdc4df..6277053143a4881f96e65e803f247c216d5505be 100644

--- a/src/IceInstX86BaseImpl.h

+++ b/src/IceInstX86BaseImpl.h

@@ -2655,9 +2655,11 @@ void InstX86Fld<Machine>::emitIAS(const Cfg *Func) const {

Asm->sub(IceType_i32,

InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp,

Width);

+ static constexpr AssemblerFixup *Fixup = nullptr;

typename InstX86Base<Machine>::Traits::Address StackSlot =

typename InstX86Base<Machine>::Traits::Address(

- InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp, 0);

+ InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp, 0,

+ Fixup);

Asm->movss(Ty, StackSlot,

InstX86Base<Machine>::Traits::RegisterSet::getEncodedXmm(

Var->getRegNum()));

@@ -2753,9 +2755,11 @@ void InstX86Fstp<Machine>::emitIAS(const Cfg *Func) const {

Immediate Width(typeWidthInBytes(Ty));

Asm->sub(IceType_i32,

InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp, Width);

+ static constexpr AssemblerFixup *Fixup = nullptr;

typename InstX86Base<Machine>::Traits::Address StackSlot =

typename InstX86Base<Machine>::Traits::Address(

- InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp, 0);

+ InstX86Base<Machine>::Traits::RegisterSet::Encoded_Reg_esp, 0,

+ Fixup);

Asm->fstp(Ty, StackSlot);

Asm->movss(Ty, InstX86Base<Machine>::Traits::RegisterSet::getEncodedXmm(

Dest->getRegNum()),