Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 14283003: Micro-optimise Length::initFromLength (Closed)

Created:
7 years, 4 months ago by Timothy Loh
Modified:
7 years, 4 months ago
Reviewers:
Eric Willigers, eseidel
CC:
blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Micro-optimise Length::initFromLength This appears to improve html5-full-render by 1-2% on my system (gcc 4.6.3) by using memcpy instead of copying members (and branching to copy the union). R=eseidel@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/core/platform/Length.h View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timothy Loh
7 years, 4 months ago (2013-04-18 01:36:39 UTC) #1
Eric Willigers
lgtm On Intel with g++ -O3, this change replaces the byte reads and writes, and ...
7 years, 4 months ago (2013-04-18 03:01:50 UTC) #2
eseidel
This is great, but I'm confused why. Doesn't one normally define either the copy constructor ...
7 years, 4 months ago (2013-04-18 05:17:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/14283003/1
7 years, 4 months ago (2013-04-18 05:22:04 UTC) #4
Timothy Loh
On 2013/04/18 05:17:32, Eric Seidel (Google) wrote: > This is great, but I'm confused why. ...
7 years, 4 months ago (2013-04-18 05:27:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=2334
7 years, 4 months ago (2013-04-18 05:55:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/14283003/1
7 years, 4 months ago (2013-04-18 06:01:03 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-04-18 06:22:43 UTC) #8
Message was sent while issue was closed.
Change committed as 148621

Powered by Google App Engine
This is Rietveld 408576698