send_monitoring_event: support for default event and gomastats

infra_libs/event_mon/test/config_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import os
 import traceback
 import unittest
 
 import infra_libs
@@ skipping 34 matching lines @@
     # so it's sane to test for changes.
     hostname = 'a'
     service_name = 'b'
     appengine_name = 'c'
 
     args = ['--event-mon-run-type', 'dry',
             '--event-mon-hostname', hostname,
             '--event-mon-service-name', service_name,
             '--event-mon-appengine-name', appengine_name]
     self._set_up_args(args=args)
-    event = config._cache['default_event']
+    event = event_mon.get_default_event()
     self.assertEquals(event.event_source.host_name, hostname)
     self.assertEquals(event.event_source.service_name, service_name)
     self.assertEquals(event.event_source.appengine_name, appengine_name)
 
   def test_run_type_file_good(self):
     try:
       with infra_libs.temporary_directory(prefix='config_test-') as tempdir:
         filename = os.path.join(tempdir, 'output.db')
         self._set_up_args(args=['--event-mon-run-type', 'file',
                                 '--event-mon-output-file', filename])
         self.assertEqual(config._router.output_file, filename)
     except Exception:  # pragma: no cover
       # help for debugging
       traceback.print_exc()
       raise
 
   # Direct setup_monitoring testing below this line.
   def test_default_event(self):
     # The protobuf structure is actually an API not an implementation detail
     # so it's sane to test for changes.
     event_mon.setup_monitoring()
-    event = config._cache['default_event']
+    event = event_mon.get_default_event()
     self.assertTrue(event.event_source.HasField('host_name'))
     self.assertFalse(event.event_source.HasField('service_name'))
     self.assertFalse(event.event_source.HasField('appengine_name'))
 
   def test_default_event_with_values(self):
     # The protobuf structure is actually an API not an implementation detail
     # so it's sane to test for changes.
     hostname = 'a'
     service_name = 'b'
     appengine_name = 'c'
 
     event_mon.setup_monitoring(
       hostname=hostname,
       service_name=service_name,
       appengine_name=appengine_name
     )
-    event = config._cache['default_event']
+    event = event_mon.get_default_event()
     self.assertEquals(event.event_source.host_name, hostname)
     self.assertEquals(event.event_source.service_name, service_name)
     self.assertEquals(event.event_source.appengine_name, appengine_name)
 
   def test_set_default_event(self):
     event_mon.setup_monitoring()
-    orig_event = config._cache['default_event']
+    orig_event = event_mon.get_default_event()
 
     # Set the new default event to something different from orig_event
     # to make sure it has changed.
     event = chrome_infra_log_pb2.ChromeInfraEvent()
     new_hostname = orig_event.event_source.host_name + '.foo'
     event.event_source.host_name = new_hostname
     event_mon.set_default_event(event)
 
-    new_event = config._cache['default_event']
+    new_event = event_mon.get_default_event()
     self.assertEquals(new_event.event_source.host_name, new_hostname)
 
   def test_set_default_event_bad_type(self):
     event_mon.setup_monitoring()
 
     # bad type
     with self.assertRaises(TypeError):
       event_mon.set_default_event({'hostname': 'foo'})
+
+  def test_get_default_event(self):
+    event_mon.setup_monitoring()
+    orig_event = config._cache['default_event']
+    self.assertEqual(orig_event, event_mon.get_default_event())

[dsansome, 2015/10/29 23:17:33]

Maybe add an assertIsNot to make sure you get a copy.

[pgervais, 2015/11/02 19:38:58]

Done.