Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 14279002: Scale TouchEvent's radius when touchscreen is in mirror mode (Closed)

Created:
7 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
7 years, 8 months ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Scale TouchEvent's radius when touchscreen is in mirror mode TouchEvent's radius on Pixel is reported in the touchscreen's native resolution. When Pixel is connected to an external screen and running in mirror mode, the radius value is too large for the external screen's low display resolution. The radius value needs to be scaled properly in this case. BUG=229932 TEST=Switching to mirror mode when connecting Pixel to a low resolution external display, following the test in the issue and make sure the radius has a sensible value. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195075

Patch Set 1 #

Patch Set 2 : header file order fix #

Total comments: 4

Patch Set 3 : fixed oshima's comments #

Total comments: 2

Patch Set 4 : adding tracking issue for TODO #

Patch Set 5 : including chromeos/display/output_configurator.h only when defined(OS_CHROMEOS) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -3 lines) Patch
M ash/display/event_transformation_handler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 1 2 3 4 3 chunks +41 lines, -1 line 0 comments Download
M ash/shell.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/display/output_configurator.h View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M chromeos/display/output_configurator.cc View 1 2 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yufeng Shen (Slow to review)
7 years, 8 months ago (2013-04-16 00:49:47 UTC) #1
oshima
https://codereview.chromium.org/14279002/diff/2001/chromeos/display/output_configurator.cc File chromeos/display/output_configurator.cc (right): https://codereview.chromium.org/14279002/diff/2001/chromeos/display/output_configurator.cc#newcode569 chromeos/display/output_configurator.cc:569: float area_ratio = 1.0; 1.0f; https://codereview.chromium.org/14279002/diff/2001/chromeos/display/output_configurator.h File chromeos/display/output_configurator.h (right): ...
7 years, 8 months ago (2013-04-18 08:38:12 UTC) #2
Yufeng Shen (Slow to review)
https://codereview.chromium.org/14279002/diff/2001/chromeos/display/output_configurator.cc File chromeos/display/output_configurator.cc (right): https://codereview.chromium.org/14279002/diff/2001/chromeos/display/output_configurator.cc#newcode569 chromeos/display/output_configurator.cc:569: float area_ratio = 1.0; On 2013/04/18 08:38:12, oshima wrote: ...
7 years, 8 months ago (2013-04-18 16:22:56 UTC) #3
oshima
lgtm https://codereview.chromium.org/14279002/diff/8001/ash/display/event_transformation_handler.cc File ash/display/event_transformation_handler.cc (right): https://codereview.chromium.org/14279002/diff/8001/ash/display/event_transformation_handler.cc#newcode77 ash/display/event_transformation_handler.cc:77: // area ratio of that touchscreen to scale ...
7 years, 8 months ago (2013-04-18 17:51:36 UTC) #4
Yufeng Shen (Slow to review)
cc derat@ for OWNERS on ash/shell.cc The change correctly remove event_transformation_handler from pre-target handlers. https://codereview.chromium.org/14279002/diff/8001/ash/display/event_transformation_handler.cc ...
7 years, 8 months ago (2013-04-18 18:05:55 UTC) #5
Daniel Erat
LGTM for ash/shell.cc
7 years, 8 months ago (2013-04-18 19:14:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/14279002/16001
7 years, 8 months ago (2013-04-18 19:19:25 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 20:21:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/14279002/3007
7 years, 8 months ago (2013-04-18 20:46:10 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 03:39:38 UTC) #10
Message was sent while issue was closed.
Change committed as 195075

Powered by Google App Engine
This is Rietveld 408576698