Issue 14273043: ppapi: Use base::MessageLoop.

Issue 14273043: ppapi: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang

Modified:
7 years, 7 months ago

Reviewers:
dmichael (off chromium), viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ppapi: Use base::MessageLoop. BUG=236029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198504

Patch Set 2 : comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -51 lines)			Patch
M	ppapi/host/resource_message_filter.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/host/resource_message_filter_unittest.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/proxy/plugin_main_nacl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppapi_proxy_test.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppapi_proxy_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_instance_proxy.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_message_loop_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_message_loop_proxy.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_network_monitor_private_proxy.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_testing_proxy.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	ppapi/proxy/proxy_completion_callback_factory.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	ppapi/shared_impl/resource_tracker.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/tracked_callback.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/tracked_callback_unittest.cc	View		4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

one nit, o/w lgtm https://codereview.chromium.org/14273043/diff/1/ppapi/proxy/ppb_testing_proxy.cc File ppapi/proxy/ppb_testing_proxy.cc (right): https://codereview.chromium.org/14273043/diff/1/ppapi/proxy/ppb_testing_proxy.cc#newcode57 ppapi/proxy/ppb_testing_proxy.cc:57: ->BelongsToCurrentThread()); nit: the -> should ...

7 years, 7 months ago (2013-05-06 15:23:22 UTC) #3

xhwang

https://codereview.chromium.org/14273043/diff/1/ppapi/proxy/ppb_testing_proxy.cc File ppapi/proxy/ppb_testing_proxy.cc (right): https://codereview.chromium.org/14273043/diff/1/ppapi/proxy/ppb_testing_proxy.cc#newcode57 ppapi/proxy/ppb_testing_proxy.cc:57: ->BelongsToCurrentThread()); On 2013/05/06 15:23:22, dmichael wrote: > nit: the ...

7 years, 7 months ago (2013-05-06 16:00:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14273043/18001

7 years, 7 months ago (2013-05-06 16:01:08 UTC) #5

Message was sent while issue was closed.

Change committed as 198504

Expand Messages | Collapse Messages