Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 14273013: Simplified BluetoothAdapterWin. (Closed)

Created:
7 years, 8 months ago by youngki
Modified:
7 years, 8 months ago
Reviewers:
keybuk
CC:
chromium-reviews, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Simplified BluetoothAdapterWin. I removed the unnecessary logic of updating |devices_| and calling DeviceChanged() and DeviceRemoved(), which are not used in Windows platform. I also added DevicesUpdated(), which updates |devices_| with paired/connected/remembered devices, and DevicesDiscovered() is used only for "discovered" devices during discovery. BUG=229636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195948

Patch Set 1 #

Patch Set 2 : Removed ScopedPtr #

Total comments: 2

Patch Set 3 : Use Initializer List #

Patch Set 4 : Merge with Head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -114 lines) Patch
M device/bluetooth/bluetooth_adapter_win.h View 3 chunks +6 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 2 chunks +16 lines, -37 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win_unittest.cc View 1 2 4 chunks +5 lines, -55 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win_unittest.cc View 1 2 3 chunks +4 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
youngki
7 years, 8 months ago (2013-04-22 19:43:31 UTC) #1
keybuk
https://chromiumcodereview.appspot.com/14273013/diff/2001/device/bluetooth/bluetooth_task_manager_win_unittest.cc File device/bluetooth/bluetooth_task_manager_win_unittest.cc (right): https://chromiumcodereview.appspot.com/14273013/diff/2001/device/bluetooth/bluetooth_task_manager_win_unittest.cc#newcode20 device/bluetooth/bluetooth_task_manager_win_unittest.cc:20: num_discovery_stopped_ = 0; Shouldn't these be initialized in the ...
7 years, 8 months ago (2013-04-22 21:04:56 UTC) #2
youngki
https://chromiumcodereview.appspot.com/14273013/diff/2001/device/bluetooth/bluetooth_task_manager_win_unittest.cc File device/bluetooth/bluetooth_task_manager_win_unittest.cc (right): https://chromiumcodereview.appspot.com/14273013/diff/2001/device/bluetooth/bluetooth_task_manager_win_unittest.cc#newcode20 device/bluetooth/bluetooth_task_manager_win_unittest.cc:20: num_discovery_stopped_ = 0; On 2013/04/22 21:04:56, keybuk wrote: > ...
7 years, 8 months ago (2013-04-23 02:57:54 UTC) #3
keybuk
lgtm
7 years, 8 months ago (2013-04-23 16:46:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/youngki@chromium.org/14273013/6001
7 years, 8 months ago (2013-04-23 17:41:11 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 17:44:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/youngki@chromium.org/14273013/20002
7 years, 8 months ago (2013-04-23 17:56:28 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 00:01:52 UTC) #8
Message was sent while issue was closed.
Change committed as 195948

Powered by Google App Engine
This is Rietveld 408576698