android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java - Issue 14271024: [Android WebView] Move the most of WebSettings into AwSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 14271024: [Android WebView] Move the most of WebSettings into AwSettings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated findbugs issues Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnScaleChangedTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java » ('j') | android_webview/native/aw_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

index da647b4443681c1596248f97ddef5dacc4017496..2045d554bc941ced1ef88313cd7faa4e79b467af 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

@@ -291,7 +291,7 @@ public class AwContentsTest extends AwTestBase {

// the page load completes which makes it slightly hard to test.

final Bitmap defaultFavicon = awContents.getFavicon();

- getContentSettingsOnUiThread(awContents).setImagesEnabled(true);

+ getAwSettingsOnUiThread(awContents).setImagesEnabled(true);

loadUrlSync(awContents, mContentsClient.getOnPageFinishedHelper(), pageUrl);

assertTrue(CriteriaHelper.pollForCriteria(new Criteria() {