Serialize a subset of WebInputEvents to protobufs.

blimp/common/input/input_event_conversions_unittest.cc

Index: blimp/common/input/input_event_conversions_unittest.cc
diff --git a/blimp/common/input/input_event_conversions_unittest.cc b/blimp/common/input/input_event_conversions_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2f0b5f31dc351cee0ee5d1e52d690ee713479cd8
--- /dev/null
+++ b/blimp/common/input/input_event_conversions_unittest.cc
@@ -0,0 +1,209 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/common/input/input_event_conversions.h"
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "blimp/common/proto/input.pb.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebGestureDevice.h"
+#include "third_party/WebKit/public/web/WebInputEvent.h"
+
+namespace blimp {
+namespace {
+
+void ValidateWebInputEventSerialization(const blink::WebInputEvent& event) {

[Kevin M, 2015/11/12 00:53:50]

This does more than just serialization... Maybe you can say that it verifies
roundtripping?

[David Trainor- moved to gerrit, 2015/11/12 16:34:28]

good idea

+  InputMessage proto;
+  WebInputEventToProto(event, &proto);
+
+  scoped_ptr<blink::WebInputEvent> new_event =
+      ProtoToWebInputEvent(proto);
+
+  EXPECT_NE(nullptr, new_event);
+  EXPECT_EQ(event.size, new_event->size);
+  EXPECT_EQ(0, memcmp(&event, new_event.get(), event.size));
+}
+
+blink::WebGestureEvent BuildBasicTestWebGestureEvent() {
+  blink::WebGestureEvent event;
+  event.timeStampSeconds = 1.23;
+  event.x = 2;
+  event.y = 3;
+  event.globalX = 4;
+  event.globalY = 5;
+  event.sourceDevice = blink::WebGestureDevice::WebGestureDeviceTouchpad;
+  return event;
+}
+
+}  // namespace
+
+TEST(InputEventConversionsTest, TestWebInputEventTypeSerialization) {
+  for (int type = blink::WebInputEvent::Type::TypeFirst;
+      type != blink::WebInputEvent::Type::TypeLast; type++) {
+    scoped_ptr<blink::WebInputEvent> event;
+    // As more input event types are serialized, add the methods to create those
+    // types of WebInputEvent objects here.
+    if (type >= blink::WebInputEvent::Type::GestureTypeFirst &&
+        type <= blink::WebInputEvent::Type::GestureTypeLast) {
+      event.reset(new blink::WebGestureEvent);
+    } else {
+      continue;
+    }
+    event->type = static_cast<blink::WebInputEvent::Type>(type);
+    ValidateWebInputEventSerialization(*event);
+  }
+}
+
+TEST(InputEventConversionsTest, TestWebGestureDeviceSerialization) {
+  blink::WebGestureEvent event;
+  event.type = blink::WebGestureEvent::Type::GestureTap;
+
+  for (int source = blink::WebGestureDevice::WebGestureDeviceUninitialized;
+      source != blink::WebGestureDevice::WebGestureDeviceTouchscreen;
+      source++) {
+    event.sourceDevice = static_cast<blink::WebGestureDevice>(source);
+    ValidateWebInputEventSerialization(event);
+  }
+}
+
+TEST(InputEventConversionsTest, TestWebGestureEvents) {
+  {

[Kevin M, 2015/11/12 00:53:50]

I recommend just creating a WebGestureEvent array and use the braced initializer
syntax to specify each of the test cases. Then you can just go plow through
those cases with a simple loop. E.Z.

[David Trainor- moved to gerrit, 2015/11/12 16:34:28]

Yeah this looks cleaner :).

+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureScrollBegin;
+    src.data.scrollBegin.deltaXHint = 2.34f;
+    src.data.scrollBegin.deltaYHint = 3.45f;
+    src.data.scrollBegin.targetViewport = true;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureScrollEnd;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureScrollUpdate;
+    src.data.scrollUpdate.deltaX = 2.34f;
+    src.data.scrollUpdate.deltaY = 3.45f;
+    src.data.scrollUpdate.velocityX = 4.56f;
+    src.data.scrollUpdate.velocityY = 5.67f;
+    src.data.scrollUpdate.previousUpdateInSequencePrevented = true;
+    src.data.scrollUpdate.preventPropagation = true;
+    src.data.scrollUpdate.inertial = true;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureFlingStart;
+    src.data.flingStart.velocityX = 2.34f;
+    src.data.flingStart.velocityY = 3.45f;
+    src.data.flingStart.targetViewport = true;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureFlingCancel;
+    src.data.flingCancel.preventBoosting = true;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureShowPress;
+    src.data.showPress.width = 2.34f;
+    src.data.showPress.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureTap;
+    src.data.tap.tapCount = 3;
+    src.data.tap.width = 2.34f;
+    src.data.tap.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureTapUnconfirmed;
+    src.data.tap.tapCount = 3;
+    src.data.tap.width = 2.34f;
+    src.data.tap.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureTapDown;
+    src.data.tapDown.width = 2.34f;
+    src.data.tapDown.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureTapCancel;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureDoubleTap;
+    src.data.tap.tapCount = 3;
+    src.data.tap.width = 2.34f;
+    src.data.tap.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureTwoFingerTap;
+    src.data.twoFingerTap.firstFingerWidth = 2.34f;
+    src.data.twoFingerTap.firstFingerHeight = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureLongPress;
+    src.data.longPress.width = 2.34f;
+    src.data.longPress.height = 3.45f;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GestureLongTap;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GesturePinchBegin;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GesturePinchEnd;
+    src.timeStampSeconds = 1.23;
+    ValidateWebInputEventSerialization(src);
+  }
+
+  {
+    blink::WebGestureEvent src = BuildBasicTestWebGestureEvent();
+    src.type = blink::WebGestureEvent::Type::GesturePinchUpdate;
+    src.data.pinchUpdate.zoomDisabled = true;
+    src.data.pinchUpdate.scale = 2.34f;
+    ValidateWebInputEventSerialization(src);
+  }
+}
+
+}  // namespace blimp