Added support for http methods when mounting routes.

Added support for http methods when mounting routes.




added support for http method matching when selecting route

BUG=

Committed: https://github.com/dart-lang/route/commit/4088017

[justinfagnani, 2013-04-19 19:20:51]

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart
File lib/server.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcode54
lib/server.dart:54: final Map<RequestPattern, StreamController> _controllers =
Make _controllers a List. See comment below.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcode72
lib/server.dart:72: * method, and not sent to any other router streams.
Add docs for [method]

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:107: for (RequestPattern reqPattern in _controllers.keys) {
if we want to be even more Darty, we can use Iterable.where (once _controllers
is a List):

var matches = _controllers.where((r) => r.matches(req))
if (!matches.isEmpty) {
  matches.first.controller.add(req);
}

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:132: class RequestPattern{
On the client-side I have a similar class called Route, might make sense to use
the same name. The only difference is that Route includes the handler. Here
Route could include the StreamController. I don't think the Map _controllers is
actually doing much as a Map, so it could be replaced by a list.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:137: bool matches(HttpRequest request){
space before {

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:137: bool matches(HttpRequest request){
you can use the "fat arrow syntax" here

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:138: return  matchesFull(url, request.uri.path) && (method ==
null || request.method.toUpperCase() == method);
we're using an 80 col limit

https://chromiumcodereview.appspot.com/14267030/diff/1/test/server_test.dart
File test/server_test.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/1/test/server_test.dart#...
test/server_test.dart:33: //should be able to specify a single uri route which
invokes
add space after //

[adambender, 2013-04-19 19:43:11]

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart
File lib/server.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcode54
lib/server.dart:54: final Map<RequestPattern, StreamController> _controllers =
On 2013/04/19 19:20:51, justinfagnani wrote:
> Make _controllers a List. See comment below.

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcode72
lib/server.dart:72: * method, and not sent to any other router streams.
On 2013/04/19 19:20:51, justinfagnani wrote:
> Add docs for [method]

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:107: for (RequestPattern reqPattern in _controllers.keys) {
On 2013/04/19 19:20:51, justinfagnani wrote:
> if we want to be even more Darty, we can use Iterable.where (once _controllers
> is a List):
> 
> var matches = _controllers.where((r) => r.matches(req))
> if (!matches.isEmpty) {
>   matches.first.controller.add(req);
> }

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:132: class RequestPattern{
On 2013/04/19 19:20:51, justinfagnani wrote:
> On the client-side I have a similar class called Route, might make sense to
use
> the same name. The only difference is that Route includes the handler. Here
> Route could include the StreamController. I don't think the Map _controllers
is
> actually doing much as a Map, so it could be replaced by a list.

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:137: bool matches(HttpRequest request){
On 2013/04/19 19:20:51, justinfagnani wrote:
> space before {

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:137: bool matches(HttpRequest request){
On 2013/04/19 19:20:51, justinfagnani wrote:
> you can use the "fat arrow syntax" here

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/lib/server.dart#newcod...
lib/server.dart:138: return  matchesFull(url, request.uri.path) && (method ==
null || request.method.toUpperCase() == method);
On 2013/04/19 19:20:51, justinfagnani wrote:
> we're using an 80 col limit

Done.

https://chromiumcodereview.appspot.com/14267030/diff/1/test/server_test.dart
File test/server_test.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/1/test/server_test.dart#...
test/server_test.dart:33: //should be able to specify a single uri route which
invokes
On 2013/04/19 19:20:51, justinfagnani wrote:
> add space after //

Done.

[justinfagnani, 2013-04-19 19:46:40]

lgtm

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart
File lib/server.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:54: final List<Route> _routes = new List<Route>();
new List<Route>() -> <Route>[]

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:127: class Route{
add space before {

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:127: class Route{
let's make this class private: _Route

[adambender, 2013-04-19 19:49:44]

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart
File lib/server.dart (right):

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:54: final List<Route> _routes = new List<Route>();
On 2013/04/19 19:46:40, justinfagnani wrote:
> new List<Route>() -> <Route>[]

Done.

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:127: class Route{
On 2013/04/19 19:46:40, justinfagnani wrote:
> let's make this class private: _Route

Done.

https://chromiumcodereview.appspot.com/14267030/diff/4001/lib/server.dart#new...
lib/server.dart:127: class Route{
On 2013/04/19 19:46:40, justinfagnani wrote:
> add space before {

Done.

[adambender, 2013-04-19 19:50:29]

Committed patchset #3 manually as r4088017 (presubmit successful).