Refactor android specific code in AudioManagerBase class.

Refactor android specific code in AudioManagerBase class.

Move android specific code into AudioManagerAndroid class.

BUG=231468
Landed in r194461.

[leozwang1, 2013-04-15 20:51:23]

Hi Dale, Following up https://chromiumcodereview.appspot.com/14049003, I moved
android specific code into Android audio manager. I also introduced two apis, 
int GetNumInputStreams();
int GetNumOutputStreams();
in AMB, so audio manager knows the number of streams. please let me know your
thoughts.

Try bots are down now, will try later again.

[DaleCurtis, 2013-04-15 21:02:30]

Much nicer! lgtm % nits.

https://codereview.chromium.org/14265014/diff/1/media/audio/android/audio_man...
File media/audio/android/audio_manager_android.h (right):

https://codereview.chromium.org/14265014/diff/1/media/audio/android/audio_man...
media/audio/android/audio_manager_android.h:30: virtual void
ReleaseOutputStream(AudioOutputStream* stream);
Missing OVERRIDE here and on the next line.

https://codereview.chromium.org/14265014/diff/1/media/audio/audio_manager_base.h
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/14265014/diff/1/media/audio/audio_manager_bas...
media/audio/audio_manager_base.h:132: int GetNumInputStreams();
Since these aren't virtual you can just hacker_style() them.

input_stream_count() { return num_input_streams_; }
output_stream_count() { return num_output_streams_; }

[leozwang1, 2013-04-15 21:12:15]

PTAL

https://codereview.chromium.org/14265014/diff/1/media/audio/android/audio_man...
File media/audio/android/audio_manager_android.h (right):

https://codereview.chromium.org/14265014/diff/1/media/audio/android/audio_man...
media/audio/android/audio_manager_android.h:30: virtual void
ReleaseOutputStream(AudioOutputStream* stream);
On 2013/04/15 21:02:30, DaleCurtis wrote:
> Missing OVERRIDE here and on the next line.

Done.

https://codereview.chromium.org/14265014/diff/1/media/audio/audio_manager_base.h
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/14265014/diff/1/media/audio/audio_manager_bas...
media/audio/audio_manager_base.h:132: int GetNumInputStreams();
On 2013/04/15 21:02:30, DaleCurtis wrote:
> Since these aren't virtual you can just hacker_style() them.
> 
> input_stream_count() { return num_input_streams_; }
> output_stream_count() { return num_output_streams_; }

Done.

[DaleCurtis, 2013-04-15 21:17:31]

https://codereview.chromium.org/14265014/diff/7001/media/audio/audio_manager_...
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/14265014/diff/7001/media/audio/audio_manager_...
media/audio/audio_manager_base.h:132: int GetNumInputStreams() { return
num_input_streams_; }
The style guide says inline methods should be hacker style, so this needs to be
num_input_streams() or, my preference, input_stream_count().  Ditto for output.

[leozwang1, 2013-04-15 21:44:55]

ptal

https://codereview.chromium.org/14265014/diff/7001/media/audio/audio_manager_...
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/14265014/diff/7001/media/audio/audio_manager_...
media/audio/audio_manager_base.h:132: int GetNumInputStreams() { return
num_input_streams_; }
sorry, corrected.

[DaleCurtis, 2013-04-15 21:49:09]

https://codereview.chromium.org/14265014/diff/16001/media/audio/android/audio...
File media/audio/android/audio_manager_android.cc (right):

https://codereview.chromium.org/14265014/diff/16001/media/audio/android/audio...
media/audio/android/audio_manager_android.cc:73: if (output_stream_count() == 1)
Sorry, just noticed this should be (stream && output_stream_count() == 1),
otherwise a failed stream creation will end up calling this a second time.

Ditto for the input side.

[leozwang1, 2013-04-15 21:59:22]

Done.

https://codereview.chromium.org/14265014/diff/16001/media/audio/android/audio...
File media/audio/android/audio_manager_android.cc (right):

https://codereview.chromium.org/14265014/diff/16001/media/audio/android/audio...
media/audio/android/audio_manager_android.cc:73: if (output_stream_count() == 1)
On 2013/04/15 21:49:09, DaleCurtis wrote:
> Sorry, just noticed this should be (stream && output_stream_count() == 1),
> otherwise a failed stream creation will end up calling this a second time.
> 
> Ditto for the input side.

Done.

https://codereview.chromium.org/14265014/diff/16001/media/audio/android/audio...
media/audio/android/audio_manager_android.cc:73: if (output_stream_count() == 1)
On 2013/04/15 21:49:09, DaleCurtis wrote:
> Sorry, just noticed this should be (stream && output_stream_count() == 1),
> otherwise a failed stream creation will end up calling this a second time.
> 
> Ditto for the input side.

Done.

[DaleCurtis, 2013-04-15 21:59:55]

lgtm

[leozwang1, 2013-04-15 22:06:42]

Thanks!, will commit it once it passes bots.