Issue 14265009: FlashCache refactorings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14265009: FlashCache refactorings. (Closed)

Created:
7 years, 8 months ago by agayev

Modified:
7 years, 8 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, gavinp+disk_chromium.org, ben+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

FlashCache refactorings. BUG=157187 TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194792

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -151 lines)			Patch
M	net/disk_cache/flash/flash_cache_test_base.h	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download
M	net/disk_cache/flash/flash_cache_test_base.cc	View	1	2 chunks	+3 lines, -19 lines	0 comments	Download
D	net/disk_cache/flash/flash_entry_unittest.cc	View	1	1 chunk	+0 lines, -48 lines	0 comments	Download
M	net/disk_cache/flash/log_store.h	View	1	3 chunks	+7 lines, -11 lines	0 comments	Download
M	net/disk_cache/flash/log_store.cc	View		4 chunks	+10 lines, -7 lines	0 comments	Download
M	net/disk_cache/flash/log_store_entry_unittest.cc	View	1	5 chunks	+13 lines, -4 lines	0 comments	Download
M	net/disk_cache/flash/log_store_unittest.cc	View	1	1 chunk	+57 lines, -40 lines	0 comments	Download
M	net/disk_cache/flash/segment_unittest.cc	View	1	5 chunks	+29 lines, -14 lines	0 comments	Download
M	net/disk_cache/flash/storage_unittest.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	net/net.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

agayev

PTAL. This is a preparation for introducing FlashBackend. Removed the FlashEntry unittest, will re-introduce with ...

7 years, 8 months ago (2013-04-15 18:37:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/14265009/2001

7 years, 8 months ago (2013-04-18 00:47:36 UTC) #3

Message was sent while issue was closed.

Change committed as 194792