Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14265002: Linux video capture, invoking mmap() with both READ and WRITE. (Closed)

Created:
7 years, 8 months ago by braveyao
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Linux video capture, invoking mmap() with both READ and WRITE. BUG=178582 TEST=media_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195150

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/video/capture/linux/video_capture_device_linux.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
braveyao
As discussed before, change mmap() with both READ and WRITE. Tested with several Logitech cameras ...
7 years, 8 months ago (2013-04-15 11:25:50 UTC) #1
wjia(left Chromium)
https://codereview.chromium.org/14265002/diff/1/media/video/capture/linux/video_capture_device_linux.cc File media/video/capture/linux/video_capture_device_linux.cc (right): https://codereview.chromium.org/14265002/diff/1/media/video/capture/linux/video_capture_device_linux.cc#newcode471 media/video/capture/linux/video_capture_device_linux.cc:471: buffer_pool_[i].start = mmap(NULL, buffer.length, PROT_READ | PROT_WRITE, Could you ...
7 years, 8 months ago (2013-04-16 22:51:18 UTC) #2
braveyao
Is this a proper one? https://codereview.chromium.org/14265002/diff/1/media/video/capture/linux/video_capture_device_linux.cc File media/video/capture/linux/video_capture_device_linux.cc (right): https://codereview.chromium.org/14265002/diff/1/media/video/capture/linux/video_capture_device_linux.cc#newcode471 media/video/capture/linux/video_capture_device_linux.cc:471: buffer_pool_[i].start = mmap(NULL, buffer.length, ...
7 years, 8 months ago (2013-04-17 02:44:37 UTC) #3
wjia(left Chromium)
lgtm with nit. https://codereview.chromium.org/14265002/diff/4001/media/video/capture/linux/video_capture_device_linux.cc File media/video/capture/linux/video_capture_device_linux.cc (right): https://codereview.chromium.org/14265002/diff/4001/media/video/capture/linux/video_capture_device_linux.cc#newcode472 media/video/capture/linux/video_capture_device_linux.cc:472: // See crbug/178582. nit: crbug.com/178582.
7 years, 8 months ago (2013-04-17 02:58:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/braveyao@chromium.org/14265002/7002
7 years, 8 months ago (2013-04-18 04:25:18 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 05:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/braveyao@chromium.org/14265002/7002
7 years, 8 months ago (2013-04-19 03:20:05 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:06:57 UTC) #8
Message was sent while issue was closed. 
Change committed as 195150

Powered by Google App Engine
This is Rietveld 408576698