Re-land: NativeTextfieldViews: Show the drop cursor when dragging text

Re-land: NativeTextfieldViews: Show the drop cursor when dragging text

First landed as r193674, reverted due to breaking tests skipped by the try bots. This CL fixes the breakage too.

NativeTextfieldViews: Show the drop cursor when dragging text. Enables RenderText users to draw cursors at specified positions through RenderText::DrawCursor. Uses this method to implement the drop cursor in NativeTextfieldViews. 

BUG=229661
TEST=Use Views Textfield; select text in omnibox; drag it around the omnibox; a cursor should be displayed at where the text will be dropped

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194903

[ckocagil, 2013-04-15 10:30:35]

sky: native_textfield_views.* are the same, could you stamp?

msw: I ended up simply returning true from RenderTextMac::IsCursorablePosition.
lgty?

[msw, 2013-04-15 17:14:04]

LGTM, with an optional suggestion.
+CC Alexei for RenderTextMac, but I think it's fine.

https://codereview.chromium.org/14264004/diff/1/ui/views/controls/textfield/n...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/14264004/diff/1/ui/views/controls/textfield/n...
ui/views/controls/textfield/native_textfield_views.cc:271: drop_cursor_position_
= GetRenderText()->FindCursorPosition(location);
You can optionally avoid calling both FindCursorPosition and IsPointInSelection
(which also calls FindCursorPosition), but you'd probably need to expose
RangeContainsCaret (protected->public). This is really optional for this CL,
I'll take another look if you choose to do it.

[Alexei Svitkine (slow), 2013-04-15 17:18:30]

lgtm

[sky, 2013-04-15 17:28:43]

LGTM

[ckocagil, 2013-04-15 20:41:15]

https://codereview.chromium.org/14264004/diff/1/ui/views/controls/textfield/n...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/14264004/diff/1/ui/views/controls/textfield/n...
ui/views/controls/textfield/native_textfield_views.cc:271: drop_cursor_position_
= GetRenderText()->FindCursorPosition(location);
On 2013/04/15 17:14:04, msw wrote:
> You can optionally avoid calling both FindCursorPosition and
IsPointInSelection
> (which also calls FindCursorPosition), but you'd probably need to expose
> RangeContainsCaret (protected->public). This is really optional for this CL,
> I'll take another look if you choose to do it.

Done.

[msw, 2013-04-15 21:05:43]

LGTM with a nit; thanks!

https://codereview.chromium.org/14264004/diff/1009/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/14264004/diff/1009/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:269: drop_cursor_position_
= GetRenderText()->FindCursorPosition(location);
nit: Inline event.location() and it's still a one-liner.

[ckocagil, 2013-04-16 19:20:24]

Will commit when the CQ opens.

https://codereview.chromium.org/14264004/diff/1009/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/14264004/diff/1009/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:269: drop_cursor_position_
= GetRenderText()->FindCursorPosition(location);
On 2013/04/15 21:05:43, msw wrote:
> nit: Inline event.location() and it's still a one-liner.

Done.

https://codereview.chromium.org/14264004/diff/15001/ui/views/controls/textfie...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/14264004/diff/15001/ui/views/controls/textfie...
ui/views/controls/textfield/native_textfield_views.cc:296:
is_drop_cursor_visible_ = false;
Added to fix a condition where OnDragDone isn't called after a drag.

[commit-bot: I haz the power, 2013-04-18 10:41:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/14264004/15001

[commit-bot: I haz the power, 2013-04-18 12:50:43]

Change committed as 194903