Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: chrome/browser/ui/global_error/global_error.h

Issue 14262009: Add support for multi-line GlobalError messages to Views. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/global_error/global_error.h
diff --git a/chrome/browser/ui/global_error/global_error.h b/chrome/browser/ui/global_error/global_error.h
index 10bd5c2da81976d1556f01ffa33cb132b81f4f1c..9fc1eeb5096047115f3b07401bae69b675a0406b 100644
--- a/chrome/browser/ui/global_error/global_error.h
+++ b/chrome/browser/ui/global_error/global_error.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
#define CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
+#include <vector>
+
#include "base/basictypes.h"
#include "base/memory/weak_ptr.h"
#include "base/string16.h"
@@ -54,6 +56,10 @@ class GlobalError : public base::SupportsWeakPtr<GlobalError> {
virtual string16 GetBubbleViewTitle() = 0;
// Returns the message for the bubble view.
virtual string16 GetBubbleViewMessage() = 0;
sail 2013/04/15 18:19:38 Could you remove this.
Yoyo Zhou 2013/04/15 18:43:28 Yes, although I would then have to rewrite Cocoa a
sail 2013/04/15 19:04:41 You can just grab the first message from the vecto
+ // Returns the messages for the bubble view. If present, takes precedence
+ // over GetBubbleViewMessage. Only supported on Views.
+ // TODO(yoz): Add support for GTK and Cocoa.
+ virtual std::vector<string16> GetBubbleViewMessages() = 0;
// Returns the accept button label for the bubble view.
virtual string16 GetBubbleViewAcceptButtonLabel() = 0;
// Returns the cancel button label for the bubble view. To hide the cancel
« no previous file with comments | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/ui/global_error/global_error_service_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698