Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/extensions/external_install_ui.cc

Issue 14262009: Add support for multi-line GlobalError messages to Views. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/external_install_ui.h" 5 #include "chrome/browser/extensions/external_install_ui.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 112
113 // GlobalError implementation. 113 // GlobalError implementation.
114 virtual Severity GetSeverity() OVERRIDE; 114 virtual Severity GetSeverity() OVERRIDE;
115 virtual bool HasMenuItem() OVERRIDE; 115 virtual bool HasMenuItem() OVERRIDE;
116 virtual int MenuItemCommandID() OVERRIDE; 116 virtual int MenuItemCommandID() OVERRIDE;
117 virtual string16 MenuItemLabel() OVERRIDE; 117 virtual string16 MenuItemLabel() OVERRIDE;
118 virtual int MenuItemIconResourceID() OVERRIDE; 118 virtual int MenuItemIconResourceID() OVERRIDE;
119 virtual void ExecuteMenuItem(Browser* browser) OVERRIDE; 119 virtual void ExecuteMenuItem(Browser* browser) OVERRIDE;
120 virtual bool HasBubbleView() OVERRIDE; 120 virtual bool HasBubbleView() OVERRIDE;
121 virtual string16 GetBubbleViewTitle() OVERRIDE; 121 virtual string16 GetBubbleViewTitle() OVERRIDE;
122 virtual string16 GetBubbleViewMessage() OVERRIDE; 122 virtual std::vector<string16> GetBubbleViewMessages() OVERRIDE;
123 virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE; 123 virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
124 virtual string16 GetBubbleViewCancelButtonLabel() OVERRIDE; 124 virtual string16 GetBubbleViewCancelButtonLabel() OVERRIDE;
125 virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE; 125 virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE;
126 virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE; 126 virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;
127 virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE; 127 virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;
128 128
129 // content::NotificationObserver implementation. 129 // content::NotificationObserver implementation.
130 virtual void Observe(int type, 130 virtual void Observe(int type,
131 const content::NotificationSource& source, 131 const content::NotificationSource& source,
132 const content::NotificationDetails& details) OVERRIDE; 132 const content::NotificationDetails& details) OVERRIDE;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 } 183 }
184 184
185 bool ExternalInstallGlobalError::HasBubbleView() { 185 bool ExternalInstallGlobalError::HasBubbleView() {
186 return false; 186 return false;
187 } 187 }
188 188
189 string16 ExternalInstallGlobalError::GetBubbleViewTitle() { 189 string16 ExternalInstallGlobalError::GetBubbleViewTitle() {
190 return string16(); 190 return string16();
191 } 191 }
192 192
193 string16 ExternalInstallGlobalError::GetBubbleViewMessage() { 193 std::vector<string16> ExternalInstallGlobalError::GetBubbleViewMessages() {
194 return string16(); 194 return std::vector<string16>();
195 } 195 }
196 196
197 string16 ExternalInstallGlobalError::GetBubbleViewAcceptButtonLabel() { 197 string16 ExternalInstallGlobalError::GetBubbleViewAcceptButtonLabel() {
198 return string16(); 198 return string16();
199 } 199 }
200 200
201 string16 ExternalInstallGlobalError::GetBubbleViewCancelButtonLabel() { 201 string16 ExternalInstallGlobalError::GetBubbleViewCancelButtonLabel() {
202 return string16(); 202 return string16();
203 } 203 }
204 204
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 268
269 bool HasExternalInstallError(ExtensionService* service) { 269 bool HasExternalInstallError(ExtensionService* service) {
270 GlobalErrorService* error_service = 270 GlobalErrorService* error_service =
271 GlobalErrorServiceFactory::GetForProfile(service->profile()); 271 GlobalErrorServiceFactory::GetForProfile(service->profile());
272 GlobalError* error = error_service->GetGlobalErrorByMenuItemCommandID( 272 GlobalError* error = error_service->GetGlobalErrorByMenuItemCommandID(
273 kMenuCommandId); 273 kMenuCommandId);
274 return !!error; 274 return !!error;
275 } 275 }
276 276
277 } // namespace extensions 277 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698