Make more VideoDecoders reinitializable.

Make more VideoDecoders reinitializable.

This follows r196424. All video decoders except for GpuVideoDecoder are
reinitializable.

BUG=233608, 141788
TEST=Updated media_unittests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196890

[xhwang, 2013-04-26 01:35:04]

PTAL

[scherkus (not reviewing), 2013-04-26 01:53:25]

lgtm w/ q + nit

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
File media/filters/gpu_video_decoder.cc (right):

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
media/filters/gpu_video_decoder.cc:248: if (demuxer_stream_) {
OOC once we move DemuxerStream out of video decoders what will we use to check
that we haven't already been initialized?

you don't have to make that change now -- I think it'll be clearer to do that
change in the CL that removes DemuxerStream :)

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
media/filters/gpu_video_decoder.cc:257: DCHECK(config.IsValidConfig() &&
!config.is_encrypted());
nit: split DCHECKs so we know which one failed

[xhwang, 2013-04-26 18:08:01]

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
File media/filters/gpu_video_decoder.cc (right):

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
media/filters/gpu_video_decoder.cc:248: if (demuxer_stream_) {
On 2013/04/26 01:53:25, scherkus wrote:
> OOC once we move DemuxerStream out of video decoders what will we use to check
> that we haven't already been initialized?
> 
> you don't have to make that change now -- I think it'll be clearer to do that
> change in the CL that removes DemuxerStream :)

That's a good point. Thanks for pointing it out. Will do it later as you
mentioned.

https://codereview.chromium.org/14256013/diff/1/media/filters/gpu_video_decod...
media/filters/gpu_video_decoder.cc:257: DCHECK(config.IsValidConfig() &&
!config.is_encrypted());
On 2013/04/26 01:53:25, scherkus wrote:
> nit: split DCHECKs so we know which one failed

Done.

[commit-bot: I haz the power, 2013-04-26 18:08:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/14256013/5001

[commit-bot: I haz the power, 2013-04-26 18:09:36]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-04-26 20:53:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/14256013/11002

[commit-bot: I haz the power, 2013-04-27 00:03:56]

Change committed as 196890