Web MIDI: Add a run-time flag in blink

Web MIDI: Add a run-time flag in blink

This change adds a run-time flag for Web MIDI API in blink.
This flag is not used now, but it's needed before Chromium side changes
are landed and will be used very soon.

BUG=163795
TEST=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148813

[Takashi Toyoshima, 2013-04-20 02:46:34]

Hi reviewers,

I'll start to upstream Web MIDI changes to blink. This is the first change to
add a run-time flag for Web MIDI API.

Chris,
Can you take a look as a WebMIDI reviewer?

Kent-san,
Can you take a look as an API owner? I needed to modify API layer to control a
run-time flag from Chromium.

Haraken,
Can you take a look as an bindings owner? I'll add a run-time flag for
navigator.requestMIDIAccess.

Thanks in advice.

[abarth-chromium, 2013-04-20 02:47:42]

lgtm

[commit-bot: I haz the power, 2013-04-20 02:48:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14254007/1

[Takashi Toyoshima, 2013-04-20 02:48:12]

wow... in 1 minute.

[abarth-chromium, 2013-04-20 03:04:58]

Sorry, the mail just happened to pop into my inbox.

I presume you're going to implement MIDI as a directory module (e.g.,
Source/modules/midi).  You should set up an OWNERS file in that directory as
well (presumably with yourself and crogers as OWNERS).

[commit-bot: I haz the power, 2013-04-20 03:25:53]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-04-20 05:43:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14254007/1

[commit-bot: I haz the power, 2013-04-20 05:51:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 06:09:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14254007/1

[commit-bot: I haz the power, 2013-04-20 06:17:44]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[tkent, 2013-04-21 01:44:27]

https://chromiumcodereview.appspot.com/14254007/diff/1/Source/WebKit/chromium...
File Source/WebKit/chromium/src/WebRuntimeFeatures.cpp (right):

https://chromiumcodereview.appspot.com/14254007/diff/1/Source/WebKit/chromium...
Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:575: return
RuntimeEnabledFeatures::setRequestMIDIAccessEnabled(enable);
The flag names are inconsistent; 'WebMIDI' and 'requestMIDIAccess'.
We had better use a consistent name.

[Takashi Toyoshima, 2013-04-22 07:11:37]

abarth: Yes, major part of our implementation will be inside modules/midi. I'll
set up an OWNERS file in the next CL.

tkent: requestMIDIAccess is not only interface which depends on WebMIDI runtime
flag. I'll add other v8 feature flags later, e.g., for MIDIMessageEvent and
MIDIConnectionEvent constructors. And I'll bind these v8 flags to one WebKit
flag. v8 feature flags are called from generated bindings code. So I cannot
change the function names, if I understand correctly.

[commit-bot: I haz the power, 2013-04-22 07:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14254007/12001

[tkent, 2013-04-22 07:34:05]

> tkent: requestMIDIAccess is not only interface which depends on WebMIDI
runtime
> flag. I'll add other v8 feature flags later, e.g., for MIDIMessageEvent and
> MIDIConnectionEvent constructors. And I'll bind these v8 flags to one WebKit
> flag. v8 feature flags are called from generated bindings code. So I cannot
> change the function names, if I understand correctly.

You don't need separated runtime flags. EnabledAtRuntime attribute can have a
flag name argument.  e.g.  [EnabledAtRuntime=webMIDI] ...

[commit-bot: I haz the power, 2013-04-22 07:50:11]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[Takashi Toyoshima (Google), 2013-04-22 07:54:14]

tkent: OK, I'll change the name.
... by the way, is it possible to commit via CQ?

[Takashi Toyoshima (Google), 2013-04-22 10:15:15]

done.

[tkent, 2013-04-22 10:47:48]

lgtm

[commit-bot: I haz the power, 2013-04-22 10:50:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14254007/16002

[commit-bot: I haz the power, 2013-04-22 11:55:24]

Change committed as 148813