Clarify that ClientCertStoreImpl::SelectClientCerts is testing-only

Clarify that ClientCertStoreImpl::SelectClientCerts is testing-only

Rename SelectClientCerts to SelectClientCertsForTesting, indicating that its
a testing only function (matching the comments). Also switch the unittests to
use a fixture, to avoid FRIEND_TEST_ALL_PREFIXES growth

BUG=none
R=wtc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197211

[Ryan Sleevi, 2013-04-19 23:37:49]

wtc: Just based on your comments on https://codereview.chromium.org/13866049/ ,
a little renaming to clarify things

Just cosmetics.

[wtc, 2013-04-19 23:57:11]

Patch set 1 LGTM.

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
File net/ssl/client_cert_store_impl_mac.cc (right):

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
net/ssl/client_cert_store_impl_mac.cc:258: #if defined(OS_MACOSX) &&
!defined(OS_IOS)

I think "defined(OS_MACOSX) &&" can be removed. This file is
named _mac.cc, so it is only used by Mac OS X, and possibly
iOS.

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
File net/ssl/client_cert_store_impl_nss.cc (right):

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
net/ssl/client_cert_store_impl_nss.cc:94: bool
ClientCertStoreImpl::SelectClientCertsForTesting(

Is this method also implemented for OpenSSL? If so, it also
needs to be renamed.

[Ryan Sleevi, 2013-04-29 22:52:18]

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
File net/ssl/client_cert_store_impl_mac.cc (right):

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
net/ssl/client_cert_store_impl_mac.cc:258: #if defined(OS_MACOSX) &&
!defined(OS_IOS)
On 2013/04/19 23:57:11, wtc wrote:
> 
> I think "defined(OS_MACOSX) &&" can be removed. This file is
> named _mac.cc, so it is only used by Mac OS X, and possibly
> iOS.

Originally did it for symmetry with the .h, but sure, we can drop it from here.

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
File net/ssl/client_cert_store_impl_nss.cc (right):

https://codereview.chromium.org/14254003/diff/1/net/ssl/client_cert_store_imp...
net/ssl/client_cert_store_impl_nss.cc:94: bool
ClientCertStoreImpl::SelectClientCertsForTesting(
On 2013/04/19 23:57:11, wtc wrote:
> 
> Is this method also implemented for OpenSSL? If so, it also
> needs to be renamed.

Nope

[commit-bot: I haz the power, 2013-04-29 22:52:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14254003/11001

[commit-bot: I haz the power, 2013-04-30 01:15:58]

Change committed as 197211