Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 14246015: Make PowerStatusView::GetRoundedBatteryPercentage() round. (Closed)

Created:
7 years, 8 months ago by Daniel Erat
Modified:
7 years, 8 months ago
Reviewers:
sadrul, jennyz
CC:
chromium-reviews, ben+watch_chromium.org
Visibility:
Public.

Description

Make PowerStatusView::GetRoundedBatteryPercentage() round. PowerStatusView::GetRoundedBatteryPercentage() truncated rather than rounding, resulting in Chrome frequently displaying a slightly-lower battery percentage than what powerd told it to display. BUG=chromium:221746 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/system/power/power_status_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
7 years, 8 months ago (2013-04-18 21:47:55 UTC) #1
jennyz
lgtm
7 years, 8 months ago (2013-04-18 21:54:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/14246015/1
7 years, 8 months ago (2013-04-18 21:58:11 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 00:58:39 UTC) #4
Message was sent while issue was closed.
Change committed as 195034

Powered by Google App Engine
This is Rietveld 408576698