base/debug/trace_event_impl.cc - Issue 14244010: Correctly handle multiple convertable argument names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_impl.cc

Issue 14244010: Correctly handle multiple convertable argument names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/trace_event_impl.cc

diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc

index 96ef2c7d2982dde4e5dca6d7dd6fd4602f44a645..9e441ca8b420b8bca42effe0a9851ef70ce8dc7f 100644

--- a/base/debug/trace_event_impl.cc

+++ b/base/debug/trace_event_impl.cc

@@ -335,8 +335,6 @@ TraceEvent::TraceEvent(

if (copy) {

CopyTraceEventParameter(&ptr, &name_, end);

for (i = 0; i < num_args; ++i) {

- if (arg_types_[i] == TRACE_VALUE_TYPE_CONVERTABLE)

- continue;

CopyTraceEventParameter(&ptr, &arg_names_[i], end);

}

« no previous file with comments | « base/debug/trace_event.h ('k') | base/debug/trace_event_unittest.cc » ('j') | no next file with comments »