Issue 14241038: Removes DiffItem, which was unused, and moves _DiffItemInternal below GenerateDiff, now its lone ca…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14241038: Removes DiffItem, which was unused, and moves _DiffItemInternal below GenerateDiff, now its lone ca… (Closed)

Created:
7 years, 8 months ago by Peter Kasting

Modified:
7 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Removes DiffItem, which was unused, and moves _DiffItemInternal below GenerateDiff, now its lone caller. No other code changes, so should be no behavioral change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195262

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -86 lines)			Patch
M	scm.py	View	2 chunks	+55 lines, -84 lines	0 comments	Download
M	tests/scm_unittest.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/trychange_unittest.py	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Peter Kasting

I'm splitting https://codereview.chromium.org/14247007/ into pieces so it's easier to review and easier to figure out ...

7 years, 8 months ago (2013-04-19 19:57:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/14241038/1

7 years, 8 months ago (2013-04-19 20:07:02 UTC) #3

Message was sent while issue was closed.

Change committed as 195262