Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 14241033: Android GLNonOwnedContext support GLVirtualContext (Closed)

Created:
7 years, 8 months ago by boliu
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android GLNonOwnedContext support GLVirtualContext GLVirtualContext expects the share group to have a "real" context. BUG=230195 Android only change. Ran through android trybots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/gl/gl_context_android.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
boliu
Ken, could you take a look?
7 years, 8 months ago (2013-04-19 16:46:28 UTC) #1
no sievers
lgtm
7 years, 8 months ago (2013-04-19 17:01:43 UTC) #2
Ken Russell (switch to Gerrit)
LGTM as long as it works.
7 years, 8 months ago (2013-04-19 20:54:58 UTC) #3
boliu
On 2013/04/19 20:54:58, kbr wrote: > LGTM as long as it works. Yep. Tested on ...
7 years, 8 months ago (2013-04-19 21:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/14241033/1
7 years, 8 months ago (2013-04-19 21:11:34 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 21:18:54 UTC) #6
Message was sent while issue was closed.
Change committed as 195289

Powered by Google App Engine
This is Rietveld 408576698