Disable the Gamepad API run-time flag for Android.

Disable the Gamepad API run-time flag for Android.

Gamepad API is not implemented on Android yet, so disabling the run-time flag.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196238

[babu, 2013-04-22 16:37:38]

Rebased the patch.

[babu, 2013-04-23 14:33:24]

Rebased the patch again.

[Peter Beverloo, 2013-04-23 14:45:52]

One textual nit, lgtm otherwise.

James, could you take a look for OWNERS?

https://codereview.chromium.org/14241027/diff/6001/content/renderer/render_th...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/14241027/diff/6001/content/renderer/render_th...
content/renderer/render_thread_impl.cc:754: //Gamepad API is not implemented on
Android yet.
There currently are no plans to add support, so I'd leave out the "yet". How
about the following comment?

// Android does not support the Gamepad API.

[babu, 2013-04-23 15:32:31]

> content/renderer/render_thread_impl.cc:754: //Gamepad API is not implemented
on
> Android yet.
> There currently are no plans to add support, so I'd leave out the "yet". How
> about the following comment?
> 
> // Android does not support the Gamepad API.

Done.

[jamesr, 2013-04-23 17:25:45]

lgtm, but this is the third patch to render_thread_impl.cc to toggle
runtime-enabled features for android I've reviewed in the past 15 minutes.  This
doesn't seem like a very sustainable process.  Should we centralize the list of
things that are enabled/not enabled somewhere other than this file?

[babu, 2013-04-24 13:54:32]

On 2013/04/23 17:25:45, jamesr wrote:
> lgtm, but this is the third patch to render_thread_impl.cc to toggle
> runtime-enabled features for android I've reviewed in the past 15 minutes. 
This
> doesn't seem like a very sustainable process.  Should we centralize the list
of
> things that are enabled/not enabled somewhere other than this file?

Thanks for lgtm.

It make sense to have a centralize place for these runtime flags. I will keep
this on my list and file a separate patch.

[commit-bot: I haz the power, 2013-04-24 18:32:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/14241027/...

[commit-bot: I haz the power, 2013-04-24 21:24:09]

Change committed as 196238