Issue 14241010: Checks for Javascript errors in Files.app's tests.

Issue 14241010: Checks for Javascript errors in Files.app's tests. (Closed)

Created:
7 years, 8 months ago by mtomasz

Modified:
7 years, 8 months ago

Reviewers:
satorux1, Haruki Sato

CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Checks for Javascript errors in Files.app's tests. This patch verifies if there are no Javascript errors at the end of each test. Along the way it removes callbackPass instances, which are not reliable and can cause false positives. TEST=Run browser_tests --test_filter="*FileManagerBrowser*" BUG=233142, 233141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195194

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
	M	chrome/browser/resources/file_manager/js/test_util.js	View		2 chunks	+17 lines, -0 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js	View		7 chunks	+29 lines, -14 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

mtomasz

@satorux, @haruki: PTAL. This change revealed a bug in Files.app's deleting which I'm going to ...

7 years, 8 months ago (2013-04-19 02:31:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14241010/1

7 years, 8 months ago (2013-04-19 03:24:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14241010/1

7 years, 8 months ago (2013-04-19 07:36:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14241010/1

7 years, 8 months ago (2013-04-19 09:03:49 UTC) #5

Message was sent while issue was closed.

lgtm

lgtm

Expand Messages | Collapse Messages