Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: ui/gl/gl_context_egl.cc

Issue 14241009: Revert "gpu: Fix Vivante's "hisilicon" GPUs" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@HUAWEI_fix_black_fix_var
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_context_egl.h ('k') | ui/gl/gl_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_context_egl.cc
diff --git a/ui/gl/gl_context_egl.cc b/ui/gl/gl_context_egl.cc
index c29eb2aed05d81598493e78f57bfd4bb0ae78eba..52c60e25e8902889995328672bd866fee7a2cdee 100644
--- a/ui/gl/gl_context_egl.cc
+++ b/ui/gl/gl_context_egl.cc
@@ -112,9 +112,6 @@ bool GLContextEGL::MakeCurrent(GLSurface* surface) {
return false;
}
- if (!RecreateSurfaceIfNeeded(surface))
- return false;
-
if (!surface->OnMakeCurrent(this)) {
LOG(ERROR) << "Could not make current.";
return false;
@@ -124,39 +121,6 @@ bool GLContextEGL::MakeCurrent(GLSurface* surface) {
return true;
}
-bool GLContextEGL::RecreateSurfaceIfNeeded(GLSurface* surface) {
- if (!surface || !surface->RecreateOnMakeCurrent())
- return true;
-
- // This is specifically needed for Vivante GPU's on Android.
- // A native view surface will not be configured correctly
- // unless we do all of the following steps after making the
- // surface current.
- GLint fbo = 0;
- glGetIntegerv(GL_FRAMEBUFFER_BINDING, &fbo);
- glBindFramebufferEXT(GL_FRAMEBUFFER, 0);
-
- eglMakeCurrent(display_,
- EGL_NO_SURFACE,
- EGL_NO_SURFACE,
- EGL_NO_CONTEXT);
- if (!surface->Recreate()) {
- LOG(ERROR) << "Failed to recreate surface";
- return false;
- }
- if (!eglMakeCurrent(display_,
- surface->GetHandle(),
- surface->GetHandle(),
- context_)) {
- LOG(ERROR) << "eglMakeCurrent failed with error "
- << GetLastEGLErrorString();
- return false;
- }
-
- glBindFramebufferEXT(GL_FRAMEBUFFER, fbo);
- return true;
-}
-
void GLContextEGL::ReleaseCurrent(GLSurface* surface) {
if (!IsCurrent(surface))
return;
« no previous file with comments | « ui/gl/gl_context_egl.h ('k') | ui/gl/gl_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698