[MIPS] Support to build libchromeview for MIPS-Android

[MIPS] Support to build libchromeview for MIPS-Android

Small set of changes in gyp files to enable build for libchromeview for
MIPS-Android.
It also includes minor change in base/debug/stack_trace_android.cc to
redefine SIGSTKFLT for MIPS, since MIPS does not have SIGSTKFLT.

BUG=130022
TEST=build libchromeview

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196938

[petarj, 2013-04-19 01:21:47]

Patch to build open source parts of libchromeview.

[cjhopman, 2013-04-19 18:02:10]

https://codereview.chromium.org/14241008/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/14241008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:15: #define SIGSTKFLT SIGSEGV
Can we just use SIGSEGV for all arches?

https://codereview.chromium.org/14241008/diff/1/build/android/envsetup_functi...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/14241008/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:38: toolchain_dir="linux-x86"
For arm/x86 toolchain_dir is set based on host_arch (in envsetup.sh). Does that
not work for mips?

https://codereview.chromium.org/14241008/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/14241008/diff/1/build/common.gypi#newcode1201
build/common.gypi:1201: 'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-9/arch-mips',
should this be android-14 like arm/x86?

https://codereview.chromium.org/14241008/diff/1/build/common.gypi#newcode1202
build/common.gypi:1202: 'android_toolchain%':
'<(android_ndk_root)/toolchains/mipsel-linux-android-4.6/prebuilt/<(host_os)-x86/bin',
"<(host_os)-<(android_host_arch)" instead of "<(host_os)-x86"?

https://codereview.chromium.org/14241008/diff/1/build/common.gypi#newcode2641
build/common.gypi:2641: 'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-9/arch-mips',
These shouldn't need to be set here. It should just use the ones above.

https://codereview.chromium.org/14241008/diff/1/build/common.gypi#newcode3349
build/common.gypi:3349:
'-L<(android_ndk_root)/sources/cxx-stl/gnu-libstdc++/4.6/libs/mips'
should this use the "-target" flag like arm/x86?

Note: I don't know what exactly it does, I just noticed the inconsistency.

[petarj, 2013-04-21 01:17:13]

Second patch set uploaded. PTAL.

https://chromiumcodereview.appspot.com/14241008/diff/1/base/debug/stack_trace...
File base/debug/stack_trace_android.cc (right):

https://chromiumcodereview.appspot.com/14241008/diff/1/base/debug/stack_trace...
base/debug/stack_trace_android.cc:15: #define SIGSTKFLT SIGSEGV
On 2013/04/19 18:02:10, cjhopman wrote:
> Can we just use SIGSEGV for all arches?

I guess we could. Would you like me to change it in this CL?

https://chromiumcodereview.appspot.com/14241008/diff/1/build/android/envsetup...
File build/android/envsetup_functions.sh (right):

https://chromiumcodereview.appspot.com/14241008/diff/1/build/android/envsetup...
build/android/envsetup_functions.sh:38: toolchain_dir="linux-x86"
On 2013/04/19 18:02:10, cjhopman wrote:
> For arm/x86 toolchain_dir is set based on host_arch (in envsetup.sh). Does
that
> not work for mips?

When host_arch is "x86_64", it expects to find folder "linux-x86_64",
but in android_tools repository, mipsel-linux-android-4.6/prebuilt/
does not have 64-bit versions.

We can change it once it becomes available.

https://chromiumcodereview.appspot.com/14241008/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/14241008/diff/1/build/common.gypi#newc...
build/common.gypi:1201: 'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-9/arch-mips',
On 2013/04/19 18:02:10, cjhopman wrote:
> should this be android-14 like arm/x86?

Done.

https://chromiumcodereview.appspot.com/14241008/diff/1/build/common.gypi#newc...
build/common.gypi:1202: 'android_toolchain%':
'<(android_ndk_root)/toolchains/mipsel-linux-android-4.6/prebuilt/<(host_os)-x86/bin',
On 2013/04/19 18:02:10, cjhopman wrote:
> "<(host_os)-<(android_host_arch)" instead of "<(host_os)-x86"?

We must force "linux-x86" for both "x86_64" and "x86" for the time being.
See the comment in envsetup_functions.sh.

https://chromiumcodereview.appspot.com/14241008/diff/1/build/common.gypi#newc...
build/common.gypi:2641: 'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-9/arch-mips',
On 2013/04/19 18:02:10, cjhopman wrote:
> These shouldn't need to be set here. It should just use the ones above.

Removed.

https://chromiumcodereview.appspot.com/14241008/diff/1/build/common.gypi#newc...
build/common.gypi:3349:
'-L<(android_ndk_root)/sources/cxx-stl/gnu-libstdc++/4.6/libs/mips'
On 2013/04/19 18:02:10, cjhopman wrote:
> should this use the "-target" flag like arm/x86?
> 
> Note: I don't know what exactly it does, I just noticed the inconsistency.

Removed completely for now.

[Yaron, 2013-04-22 22:06:07]

https://chromiumcodereview.appspot.com/14241008/diff/1/build/android/envsetup...
File build/android/envsetup_functions.sh (right):

https://chromiumcodereview.appspot.com/14241008/diff/1/build/android/envsetup...
build/android/envsetup_functions.sh:38: toolchain_dir="linux-x86"
On 2013/04/21 01:17:14, petarj wrote:
> On 2013/04/19 18:02:10, cjhopman wrote:
> > For arm/x86 toolchain_dir is set based on host_arch (in envsetup.sh). Does
> that
> > not work for mips?
> 
> When host_arch is "x86_64", it expects to find folder "linux-x86_64",
> but in android_tools repository, mipsel-linux-android-4.6/prebuilt/
> does not have 64-bit versions.
> 
> We can change it once it becomes available.
> 

Does this actually build when not using a 64-bit toolchain? For other
architectures that was unavoidable (e.g. unit_tests.so wouldn't link).

[petarj, 2013-04-23 13:52:24]

On 2013/04/22 22:06:07, Yaron wrote:
> Does this actually build when not using a 64-bit toolchain? For other
> architectures that was unavoidable (e.g. unit_tests.so wouldn't link).

Yes, it does build. What link problems did you have?
"Memory exhausted" failure?

[petarj, 2013-04-24 23:20:43]

Any other remarks?

[cjhopman, 2013-04-26 17:31:30]

lgtm

[commit-bot: I haz the power, 2013-04-26 17:52:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/14241008/14001

[commit-bot: I haz the power, 2013-04-26 17:52:19]

Failed to apply patch for build/common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/common.gypi
  Hunk #1 FAILED at 941.
  Hunk #2 succeeded at 1203 (offset 15 lines).
  Hunk #3 succeeded at 2957 (offset 50 lines).
  Hunk #4 succeeded at 4292 (offset 63 lines).
  1 out of 4 hunks FAILED -- saving rejects to file build/common.gypi.rej

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
0615c5ea807de4f37c348b943efdc8dee182aa4f..4ed4d1dfa9ec5072495ffd4f793539553430e7f8
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -941,6 +941,9 @@
     # arm_neon==0).
     'arm_fpu%': 'vfpv3',
 
+    # Default arch variant for MIPS.
+    'mips_arch_variant%': 'mips32r2',
+
     # Set ARM float abi compilation flag.
     'arm_float_abi%': 'softfp',
 
@@ -1188,6 +1191,12 @@
               'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-14/arch-arm',
               'android_toolchain%':
'<(android_ndk_root)/toolchains/arm-linux-androideabi-4.6/prebuilt/<(host_os)-<(android_host_arch)/bin',
             }],
+            ['target_arch == "mipsel"', {
+              'android_app_abi%': 'mips',
+              'android_gdbserver%':
'<(android_ndk_root)/prebuilt/android-mips/gdbserver/gdbserver',
+              'android_ndk_sysroot%':
'<(android_ndk_root)/platforms/android-14/arch-mips',
+              'android_toolchain%':
'<(android_ndk_root)/toolchains/mipsel-linux-android-4.6/prebuilt/<(host_os)-x86/bin',
+            }],
           ],
         },
         # Copy conditionally-set variables out one scope.
@@ -2901,6 +2910,30 @@
               }],
             ],
           }],
+          ['target_arch=="mipsel"', {
+            'target_conditions': [
+              ['_toolset=="target"', {
+                'conditions': [
+                  ['mips_arch_variant=="mips32r2"', {
+                    'cflags': ['-mips32r2', '-Wa,-mips32r2'],
+                  }, {
+                    'cflags': ['-mips32', '-Wa,-mips32'],
+                  }],
+                ],
+                'cflags': [
+                  '-EL',
+                  '-mhard-float',
+                ],
+                'ldflags': [
+                  '-EL',
+                  '-Wl,--no-keep-memory'
+                ],
+                'cflags_cc': [
+                  '-Wno-uninitialized',
+                ],
+              }],
+            ],
+          }],
           ['linux_fpic==1', {
             'cflags': [
               '-fPIC',
@@ -4199,7 +4232,7 @@
         ['LINK.host', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} <!(which
g++))'],
       ],
     }],
-    ['target_arch=="mipsel"', {
+    ['OS=="linux" and target_arch=="mipsel"', {
       'make_global_settings': [
         ['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'],
         ['CXX', '<(sysroot)/../bin/mipsel-linux-gnu-g++'],

[commit-bot: I haz the power, 2013-04-27 00:38:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/14241008/23001

[commit-bot: I haz the power, 2013-04-27 04:10:27]

Change committed as 196938