Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 14241007: Return the shared context's handle when a virtualized context's (Closed)

Created:
7 years, 8 months ago by ccameron
Modified:
7 years, 8 months ago
Reviewers:
danakj, greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Return the shared context's handle when a virtualized context's handle is requested. GLES2DecoderImpl::DoTexImageIOSurface2DCHROMIUM uses GLContext::GetHandle's result as an argument to CGLTexImageIOSurface2D, which expects a valid CGLContextObj as the handle (not NULL). BUG=230300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
7 years, 8 months ago (2013-04-19 00:49:13 UTC) #1
ccameron
Ping.
7 years, 8 months ago (2013-04-19 21:27:35 UTC) #2
greggman
On 2013/04/19 21:27:35, ccameron1 wrote: > Ping. lgtm
7 years, 8 months ago (2013-04-19 23:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/14241007/1
7 years, 8 months ago (2013-04-19 23:04:47 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-20 12:36:10 UTC) #5
Message was sent while issue was closed.
Change committed as 195390

Powered by Google App Engine
This is Rietveld 408576698