Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 14238038: Need to take an element's scroll offset into account when painting its column rules. (Closed)

Created:
7 years, 7 months ago by mstensho (USE GERRIT)
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, jchaffraix+rendering, Julien - ping for review
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Need to take an element's scroll offset into account when painting its column rules. R= BUG=236315 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
A LayoutTests/fast/multicol/scrolling-column-rules.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/scrolling-column-rules-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mstensho (USE GERRIT)
7 years, 7 months ago (2013-05-14 08:55:29 UTC) #1
mstensho (USE GERRIT)
7 years, 6 months ago (2013-06-12 09:46:17 UTC) #2
mstensho (USE GERRIT)
This patch is for the current multicol implementation. At some point I really I hope ...
7 years, 4 months ago (2013-08-01 09:21:29 UTC) #3
mstensho (USE GERRIT)
On 2013/08/01 09:21:29, Morten Stenshorne wrote: > This patch is for the current multicol implementation. ...
7 years, 2 months ago (2013-09-26 08:11:23 UTC) #4
eseidel
lgtm
7 years, 2 months ago (2013-09-26 16:29:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/14238038/1
7 years, 2 months ago (2013-09-26 16:41:17 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 17:49:19 UTC) #7
Message was sent while issue was closed.
Change committed as 158386

Powered by Google App Engine
This is Rietveld 408576698