chrome/browser/managed_mode/managed_user_service.cc - Issue 14238037: Made it possible to tell whether an extension is being installed or updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/managed_mode/managed_user_service.cc

Issue 14238037: Made it possible to tell whether an extension is being installed or updated. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added extra check. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_startup_installer_browsertest.cc ('k') | chrome/browser/performance_monitor/performance_monitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/managed_mode/managed_user_service.cc

diff --git a/chrome/browser/managed_mode/managed_user_service.cc b/chrome/browser/managed_mode/managed_user_service.cc

index 12708c189cc9361b51a6ee7203e87d602d52c79b..e494f95f6a0063bd159d7e3e7f896a9164db44e2 100644

--- a/chrome/browser/managed_mode/managed_user_service.cc

+++ b/chrome/browser/managed_mode/managed_user_service.cc

@@ -278,10 +278,16 @@ void ManagedUserService::Observe(int type,

}

break;

}

- case chrome::NOTIFICATION_EXTENSION_INSTALLED:

+ case chrome::NOTIFICATION_EXTENSION_INSTALLED: {

+ // Remove the temporary elevation.

+ const extensions::Extension* extension =

+ content::Details<const extensions::InstalledExtensionInfo>(details)->

+ extension;

+ RemoveElevationForExtension(extension->id());

+ break;

+ }

case chrome::NOTIFICATION_EXTENSION_UNINSTALLED: {

- // When an extension was installed or uninstalled, remove the temporary

- // elevation.

+ // Remove the temporary elevation.

const extensions::Extension* extension =

content::Details<extensions::Extension>(details).ptr();

RemoveElevationForExtension(extension->id());