Rename Instant browser tests

Rename Instant browser tests to interactive_ui_tests to make it clear.

BUG=230621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195483

[commit-bot: I haz the power, 2013-04-14 08:34:50]

No reviewers yet.

[Haojian Wu, 2013-04-14 08:41:19]

@sreeram, please review it.

[sreeram, 2013-04-14 17:22:35]

On 2013/04/14 08:41:19, Haojian Wu wrote:
> @sreeram, please review it.

Looks good. Could you also rename instant_extended_manual_browsertest.cc ->
instant_extended_manual_interactive_ui_test.cc ? Thanks.

[hokein.wu_gmail.com, 2013-04-17 02:34:10]

Done. please review it again.

On Mon, Apr 15, 2013 at 1:22 AM, <sreeram@chromium.org> wrote:

> On 2013/04/14 08:41:19, Haojian Wu wrote:
>
>> @sreeram, please review it.
>>
>
> Looks good. Could you also rename instant_extended_manual_**browsertest.cc
> ->
> instant_extended_manual_**interactive_ui_test.cc ? Thanks.
>
>
https://codereview.chromium.**org/14235006/<https://codereview.chromium.org/1...
>

[sreeram, 2013-04-17 06:03:20]

lgtm

[James Cook, 2013-04-17 18:29:25]

On 2013/04/17 06:03:20, sreeram wrote:
> lgtm

From chrome_tests.gypi it looks like we more commonly use "interactive_uitests"
(one underscore).

[sreeram, 2013-04-17 18:31:06]

On second thought, per @jamescook's advice, could you make ui_test a single word
(uitest), so that the files are:
instant_extended_interactive_uitest.cc
instant_extended_manual_interactive_uitest.cc
instant_interactive_uitest.cc

Thanks!

[Haojian Wu, 2013-04-18 00:20:38]

Done.

On 2013/04/17 18:31:06, sreeram wrote:
> On second thought, per @jamescook's advice, could you make ui_test a single
word
> (uitest), so that the files are:
> instant_extended_interactive_uitest.cc
> instant_extended_manual_interactive_uitest.cc
> instant_interactive_uitest.cc
> 
> Thanks!

[sreeram, 2013-04-18 01:50:07]

SLGTM

Thanks!

[Haojian Wu, 2013-04-19 00:48:00]

ping @jamescook

[sreeram, 2013-04-19 01:39:04]

On 2013/04/19 00:48:00, Haojian Wu wrote:
> ping @jamescook

You don't need James's approval here. I've clicked the CQ button on your behalf.

[commit-bot: I haz the power, 2013-04-19 01:39:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/11001

[commit-bot: I haz the power, 2013-04-19 01:39:39]

Presubmit check for 14235006-11001 failed and returned exit status 1.

INFO:root:Found 4 file(s).
INFO:PRESUBMIT:Valid authors are *@chromium.org, *@google.com,
ibraaaa@gmail.com, rryk.ua@gmail.com, sanxiyn@gmail.com, alexscheele@gmail.com,
me@bramp.net, phajdan.jr@gmail.com, jesse@jmiller.biz, szymonpiechowicz@o2.pl,
vega.james@gmail.com, gothicx@gmail.com, reimarvin@gmail.com,
drpizza@quiscalusmexicanus.org, developer0420@gmail.com, yado.masa@gmail.com,
yarin.kaul@gmail.com, mendola@gmail.com, craig.schlenter@gmail.com,
ibrar.ahmad@gmail.com, takano.naoki@gmail.com, fta@sofaraway.org,
kunalt@gmail.com, m0.interactive@gmail.com, jroesslein@gmail.com,
sy3620@gmail.com, bekkra@gmail.com, raman.tenneti@gmail.com, kpn24@drexel.edu,
kimworking@gmail.com, paulrobinson85@googlemail.com, jorat1346@gmail.com,
tedoc2000@gmail.com, himikof@gmail.com, sean@cyberwang.net,
rsesek@bluestatic.org, j.dinata@gmail.com, chromium@willhirsch.co.uk,
yoav.zilberberg@gmail.com, joel@jms.id.au, jacob@mandelson.org,
yuri.gorobets@gmail.com, pwicks86@gmail.com, thiago.farina@gmail.com,
viettrungluu@gmail.com, pierre.lafayette@gmail.com, ffmpeg@gmail.com,
philippe.beauchamp@gmail.com, vedran.sajatovic@gmail.com,
randy.posynick@gmail.com, bruno@flock.com, jsorianopastor@gmail.com,
bdonlan@gmail.com, artagnon@gmail.com, dominic.jodoin@gmail.com,
googlecontrib@velox.ch, clemens@endorphin.org, sig11@reprehensible.net,
voyageur@gentoo.org, vt@foilhead.net, alexander@sulfrian.net,
philippe.beaudoin@gmail.com, mhahnenb@andrew.cmu.edu, agartrell@cmu.edu,
leith@leithalweapon.geek.nz, jchoi42@pha.jhu.edu, paul.l.kehrer@gmail.com,
chamalsl@yahoo.com, jaysoffian@gmail.com, bgmerrell@gmail.com,
appamatto@gmail.com, bgmerrell@gmail.com, ryan-chromium-dev@sleevi.com,
satoshi.matsuzaki@gmail.com, pcgod99@gmail.com, ningxin.hu@intel.com,
james.wei@intel.com, haitao.feng@intel.com, weinjared@gmail.com,
melvinxie@gmail.com, floppymaster@gmail.com, giuseppe@iuculano.it,
jwillcox@litl.com, v.a.shreyas@gmail.com, spenn@engr.uvic.ca,
jorge@tomatocannon.com, pnettleship@gmail.com, davidben@mit.edu,
venture37@geeklan.co.uk, peter@chromium.org, lauri.oherd@gmail.com,
eschew@gmail.com, sam@sammcd.com, fuzzac@gmail.com, kushi.p@gmail.com,
m.b.lankhorst@gmail.com, vipul.bhasin@gmail.com, rnorton10@gmail.com,
dill.sellars@gmail.com, seshadri.mahalingam@gmail.com, clementskau@gmail.com,
david.mike.futcher@gmail.com, ramkumar.gokarnesan@gmail.com,
mma.public@gmail.com, chromium@hybridsource.org, *@nvidia.com,
google@tk-webart.de, pph34r@gmail.com, lukezarko@gmail.com, fhd@ubercode.de,
ali.akbar@gmail.com, mathias@qiwi.be, mrs@mythic-beasts.com,
amruthraj@motorola.com, ckqr36@motorola.com, wxjg68@motorola.com,
ehsan.akhgari@gmail.com, chrelad@gmail.com, ncj674@motorola.com,
mtilburg@adobe.com, pbrophy@adobe.com, goldberg@adobe.com, woodward@adobe.com,
vinaya@adobe.com, naveenbobbili@motorola.com, vamshi@motorola.com,
robert.nagy@gmail.com, qtc746@motorola.com, blr.bmlab@gmail.com,
wrm364@motorola.com, rosen.dash@gmail.com, qghc36@motorola.com,
ravi.kasibhatla@motorola.com, nqk836@motorola.com, nrqv63@motorola.com,
tedvessenes@gmail.com, progame@chromium.org, brk376@motorola.com,
cristian.patrasciuc@gmail.com, halton.huo@intel.com, aofdwsl@gmail.com,
gaochun.dev@gmail.com, clintstaley@gmail.com, clintstaley@chromium.org,
rdevlin.cronin@gmail.com, junmin.zhu@intel.com, cem.kocagil@gmail.com,
simon.hong81@gmail.com, guanqun.lu@gmail.com, beaufort.francois@gmail.com,
eriq.augustine@gmail.com, francoisk777@gmail.com, erikghill@gmail.com,
maojie0924@gmail.com, pan.deng@intel.com, aaronlevbugs@gmail.com,
peter@pcc.me.uk, aaron.randolph@gmail.com, yumios.art@gmail.com,
matthewrobertson03@gmail.com, yujie.mao@intel.com, samuel.xu@intel.com,
jin.a.yang@intel.com, hexinchao@gmail.com, changbin.shao@intel.com,
stephen.searles@gmail.com, arun.m@samsung.com, trprice@gmail.com,
achicu@adobe.com, ekr@rtfm.com, wiss1976@gmail.com, erik.sjolund@gmail.com,
simon.arlott@gmail.com, alexkorep@gmail.com, mitchellwrosen@chromium.org,
yongsheng.zhu@intel.com, shouqun.liu@intel.com, kangyuan.shu@intel.com,
jake@helfert.us, hongbo.min@intel.com, tom.cassiotis@gmail.com,
evangelos@foutrelis.com, paivanof@gmail.com, rb@radix.io, petarj@mips.com,
carloschilazo@gmail.com, mmaerean@adobe.com, kaustubh.ra@gmail.com,
betravis@adobe.com, bear.travis@gmail.com, mvujovic@adobe.com,
jakob.j.w@googlemail.com, badea@adobe.com, joshua.lock@intel.com,
chunyang.dai@intel.com, mhx348@motorola.com, rubentopo@gmail.com,
josh.triplett@intel.com, qiankun.miao@intel.com, etienne@atnnn.com,
yang.gu@intel.com, ttr314@googlemail.com, limasdf@gmail.com,
m.s.bednorz@gmail.com, kamil.jiwa@gmail.com, keenepan@linpus.com,
unsafe@trevp.net, rosca@adobe.com, sylvinus@gmail.com, sungmann.cho@gmail.com,
fangjue23303@gmail.com, evan.peterson.ep@gmail.com, jryans@chromium.org,
matheusbrat@gmail.com, olaru@adobe.com, horia.olaru@gmail.com, *@opera.com,
johannes.rudolph@googlemail.com, samusaaron3@gmail.com, qufighter@gmail.com,
jun.a.jiang@intel.com, bobbypowers@gmail.com, patrickriordan177@gmail.com,
kenneth.r.christiansen@intel.com, raphael.kubo.da.costa@intel.com,
*@yandex-team.ru

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit Warnings **
Hokein.Wu@gmail.com is not in AUTHORS file. If you are a new contributor, please
visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.3s to calculate.

[Haojian Wu, 2013-04-19 01:53:16]

Thanks for your explanation. Since I'm the first time to contribute chromium
project, I am not exactly known the details of chromium development.  Is CQ
button clicked by the contributor, not the reviewer?
On 2013/04/19 01:39:04, sreeram wrote:
> You don't need James's approval here. I've clicked the CQ button on your
behalf.

[Haojian Wu, 2013-04-19 01:57:29]

@sreeram, I have add my name into the AUTHORS file and signed the CLA on the
website.

[sreeram, 2013-04-19 01:57:32]

On 2013/04/19 01:53:16, Haojian Wu wrote:
> Thanks for your explanation. Since I'm the first time to contribute chromium
> project, I am not exactly known the details of chromium development.  Is CQ
> button clicked by the contributor, not the reviewer?

Usually the author (contributor) clicks the CQ button, after they have gotten
all the necessary approvals.

In this case, the CQ attempt failed because you (the author) haven't yet signed
the CLA. Please follow the instructions at
http://www.chromium.org/developers/contributing-code.

[Haojian Wu, 2013-04-19 02:02:33]

On 2013/04/19 01:57:32, sreeram wrote:
> Usually the author (contributor) clicks the CQ button, after they have gotten
> all the necessary approvals.

And How can I know all the *necessary* approvals? through the OWNERS file or the
log messages?

[sreeram, 2013-04-19 02:10:57]

On 2013/04/19 02:02:33, Haojian Wu wrote:
> On 2013/04/19 01:57:32, sreeram wrote:
> > Usually the author (contributor) clicks the CQ button, after they have
gotten
> > all the necessary approvals.
> 
> And How can I know all the *necessary* approvals? through the OWNERS file or
the
> log messages?

Usually the presubmit script that runs when you do a "git cl upload" should tell
you whose approvals are needed. Yes, you can also do it manually by inspecting
the OWNERS files in directories that contain files in your CL.

[Haojian Wu, 2013-04-19 02:15:34]

On 2013/04/19 02:10:57, sreeram wrote:
> Usually the presubmit script that runs when you do a "git cl upload" should
tell
> you whose approvals are needed. Yes, you can also do it manually by inspecting
> the OWNERS files in directories that contain files in your CL.

Thanks in advance. Your explanation is very helpfule.Now I'm more clear than
before. 

I have updated the AUTHORS file. Should I click the CQ button now? or still need
your LGTM?

[commit-bot: I haz the power, 2013-04-19 02:16:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/20001

[commit-bot: I haz the power, 2013-04-19 02:16:02]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
6c6622be0b5964eded1fea99aacf94ee27963608..f2be9b09cf841a20592e9d5d70294c8c677d8081
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -233,3 +233,4 @@ Sam Larison <qufighter@gmail.com>
 Jun Jiang <jun.a.jiang@intel.com>
 Bobby Powers <bobbypowers@gmail.com>
 Patrick Riordan <patrickriordan177@gmail.com>
+Haojian Wu <hokein.wu@gmail.com>

[sreeram, 2013-04-19 02:19:03]

Thanks for signing the CLA and adding your email to the AUTHORS file.

It looks like the patch failed to apply. Please "gclient sync", re-upload the
patch, and go ahead and click the CQ button yourself.

(In general, once a reviewer has LGTMed a CL, there's no need to ask them again
if you have to upload new patches to fix minor issues such as rebaselining to
fix merge conflicts.)

[Haojian Wu, 2013-04-19 02:21:27]

On 2013/04/19 02:16:02, I haz the power (commit-bot) wrote:
> Failed to apply patch for AUTHORS:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file AUTHORS
>   Hunk #1 FAILED at 233.
>   1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej
> 
> Patch:       AUTHORS
> Index: AUTHORS
> diff --git a/AUTHORS b/AUTHORS
> index
>
6c6622be0b5964eded1fea99aacf94ee27963608..f2be9b09cf841a20592e9d5d70294c8c677d8081
> 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -233,3 +233,4 @@ Sam Larison <mailto:qufighter@gmail.com>
>  Jun Jiang <mailto:jun.a.jiang@intel.com>
>  Bobby Powers <mailto:bobbypowers@gmail.com>
>  Patrick Riordan <mailto:patrickriordan177@gmail.com>
> +Haojian Wu <mailto:hokein.wu@gmail.com>

@sreeram, What's the problem here? The presubmit script running in my local
machine normally, without any waring. Is the AUTHORS file conflicted with
upstream?

[commit-bot: I haz the power, 2013-04-19 02:40:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/19002

[commit-bot: I haz the power, 2013-04-19 02:41:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-04-19 02:50:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/19002

[commit-bot: I haz the power, 2013-04-19 14:46:17]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 236.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
2b48d4dca82b8238dce10354063bc176f57fcc19..7b5cd60d0ca2b41983c19b61d7dd329e167be04d
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -236,3 +236,4 @@ Patrick Riordan <patrickriordan177@gmail.com>
 Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>
 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
 Yandex LLC <*@yandex-team.ru>
+Haojian Wu <hokein.wu@gmail.com>

[commit-bot: I haz the power, 2013-04-19 16:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/29004

[commit-bot: I haz the power, 2013-04-19 18:19:15]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[Haojian Wu, 2013-04-22 01:53:28]

Hi, @screeram

Could you tell me what's wrong with my CL? It seems always failed. I have no
idea about it.

Thanks in advance.

[sreeram, 2013-04-22 02:29:11]

On 2013/04/22 01:53:28, Haojian Wu wrote:
> Could you tell me what's wrong with my CL? It seems always failed. I have no
> idea about it.

I don't think there's anything wrong with your CL. The "update" and
"content_browsertests" failures were flakes, and the "AUTHORS" failure was just
a merge issue.

So, I'd just rebase ("gclient sync"), upload a new patch, and hit the CQ button
again.

[commit-bot: I haz the power, 2013-04-22 07:59:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/34001

[commit-bot: I haz the power, 2013-04-22 07:59:36]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 238.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
ca766ab66f783f0670b48b55a349968e0790baa6..2ffa1c62eeb2ecefafc120d7115ee6c8f51218e9
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -238,3 +238,4 @@ Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
 Yandex LLC <*@yandex-team.ru>
 Yoshinori Sano <yoshinori.sano@gmail.com>
 Mrunal Kapade <mrunal.kapade@intel.com>
+Haojian Wu <hokein.wu@gmail.com>

[commit-bot: I haz the power, 2013-04-22 08:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/14235006/38001

[commit-bot: I haz the power, 2013-04-22 10:15:54]

Change committed as 195483