Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 14234006: [net/dns] When testing for IPv6, discard link local and Teredo addresses (measurement) (Closed)

Created:
7 years, 8 months ago by szym
Modified:
7 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Visibility:
Public.

Description

[net/dns] When testing for IPv6, discard link local and Teredo addresses (measurement) BUG=223876 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194023

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename to IsGloballyReachable, use DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M net/dns/host_resolver_impl.cc View 1 2 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szym
This is still exploratory, so I see no need to change the histogram names for ...
7 years, 8 months ago (2013-04-12 14:45:54 UTC) #1
mmenke
LGTM https://codereview.chromium.org/14234006/diff/1/net/dns/host_resolver_impl.cc File net/dns/host_resolver_impl.cc (right): https://codereview.chromium.org/14234006/diff/1/net/dns/host_resolver_impl.cc#newcode187 net/dns/host_resolver_impl.cc:187: if (endpoint.GetFamily() == ADDRESS_FAMILY_IPV6) { Is there any ...
7 years, 8 months ago (2013-04-12 17:34:25 UTC) #2
szym
https://codereview.chromium.org/14234006/diff/1/net/dns/host_resolver_impl.cc File net/dns/host_resolver_impl.cc (right): https://codereview.chromium.org/14234006/diff/1/net/dns/host_resolver_impl.cc#newcode187 net/dns/host_resolver_impl.cc:187: if (endpoint.GetFamily() == ADDRESS_FAMILY_IPV6) { On 2013/04/12 17:34:25, mmenke ...
7 years, 8 months ago (2013-04-12 17:35:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/14234006/2002
7 years, 8 months ago (2013-04-12 19:36:56 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 21:58:19 UTC) #5
Message was sent while issue was closed.
Change committed as 194023

Powered by Google App Engine
This is Rietveld 408576698