Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 14232021: removed unused variation ids (Closed)

Created:
7 years, 8 months ago by Harry McCleave
Modified:
7 years, 7 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

removed unused variation ids BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/common/metrics/variations/variation_ids.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
lgtm
7 years, 8 months ago (2013-04-18 15:27:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/14232021/1
7 years, 8 months ago (2013-04-18 20:38:58 UTC) #2
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30392
7 years, 8 months ago (2013-04-19 00:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/14232021/1
7 years, 8 months ago (2013-04-19 18:50:34 UTC) #4
commit-bot: I haz the power
Change committed as 195288
7 years, 8 months ago (2013-04-19 21:18:40 UTC) #5
Alexei Svitkine (slow)
Can you re-land this change, now that the ids are no longer unused?
7 years, 7 months ago (2013-05-16 20:55:14 UTC) #6
Harry McCleave
On 2013/05/16 20:55:14, Alexei Svitkine wrote: > Can you re-land this change, now that the ...
7 years, 7 months ago (2013-05-16 21:07:17 UTC) #7
Alexei Svitkine (slow)
7 years, 7 months ago (2013-05-16 21:10:29 UTC) #8
Message was sent while issue was closed.
On 2013/05/16 21:07:17, Harry McCleave wrote:
> On 2013/05/16 20:55:14, Alexei Svitkine wrote:
> > Can you re-land this change, now that the ids are no longer unused?
> 
> I will when the experiment concludes, this was reverted as it now is using the
> ID's/gws.

Ah, you already reverted it? That's what I meant.

I didn't see it pass by.

You don't need to remove these when the experiment concludes.

Powered by Google App Engine
This is Rietveld 408576698