Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: chrome/browser/search_engines/template_url_parser.h

Issue 14232019: Do not use a UIThreadSearchTermsData when validating a TemplateURL for which the Profile is NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_parser.h
diff --git a/chrome/browser/search_engines/template_url_parser.h b/chrome/browser/search_engines/template_url_parser.h
index c7b327b3b05a0e2809b7d3086df92c9bb64283d3..82a1be77eb6349113aabf75fd6d2eed813fb9255 100644
--- a/chrome/browser/search_engines/template_url_parser.h
+++ b/chrome/browser/search_engines/template_url_parser.h
@@ -28,13 +28,15 @@ class TemplateURLParser {
};
// Decodes the chunk of data representing a TemplateURL, creates the
- // TemplateURL, and returns it. The caller owns the returned object. Returns
- // NULL if data does not describe a valid TemplateURL, the URLs referenced do
- // not point to valid http/https resources, or for some other reason we do not
- // support the described TemplateURL. |parameter_filter| can be used if you
- // want to filter some parameters out of the URL. For example, when importing
- // from another browser, we remove any parameter identifying that browser. If
- // set to NULL, the URL is not modified.
+ // TemplateURL, and returns it. The caller owns the returned object.
+ // |profile| should only be non-NULL if this function is called on the UI
+ // thread. Returns NULL if data does not describe a valid TemplateURL, the
+ // URLs referenced do not point to valid http/https resources, or for some
+ // other reason we do not support the described TemplateURL.
+ // |parameter_filter| can be used if you want to filter some parameters out of
+ // the URL. For example, when importing from another browser, we remove any
+ // parameter identifying that browser. If set to NULL, the URL is not
+ // modified.
static TemplateURL* Parse(Profile* profile,
bool show_in_default_list,
const char* data,
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698