Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3548)

Unified Diff: chrome/browser/ui/search/instant_extended_browsertest.cc

Issue 14232007: InstantExtended: don't preload the local NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_extended_browsertest.cc
diff --git a/chrome/browser/ui/search/instant_extended_browsertest.cc b/chrome/browser/ui/search/instant_extended_browsertest.cc
index 6ae70e88ff7cd09881a9cc3ca9f0959d0df8a5eb..4dd50146246590e31a85c4749c66dea1c133b818 100644
--- a/chrome/browser/ui/search/instant_extended_browsertest.cc
+++ b/chrome/browser/ui/search/instant_extended_browsertest.cc
@@ -1475,17 +1475,16 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, AutocompleteProvidersDone) {
EXPECT_EQ(1, on_native_suggestions_calls_);
}
-// Test that the local NTP doesn't end up with the local overlay's URL.
-IN_PROC_BROWSER_TEST_F(InstantExtendedTest, LocalNTPIsNotLocalOverlay) {
+// Test that the local NTP is not preloaded.
+IN_PROC_BROWSER_TEST_F(InstantExtendedTest, LocalNTPIsNotPreloaded) {
ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
EXPECT_EQ(instant_url(), instant()->ntp_->contents()->GetURL());
- // The second argument says to use only the local overlay.
+ // The second argument says to use only the local overlay and NTP.
instant()->SetInstantEnabled(false, true);
- EXPECT_EQ(GURL(chrome::kChromeSearchLocalNtpUrl),
- instant()->ntp_->contents()->GetURL());
+ EXPECT_EQ(NULL, instant()->ntp());
}
// Verify top bars visibility when searching on |DEFAULT| pages and switching

Powered by Google App Engine
This is Rietveld 408576698