Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3247)

Unified Diff: chrome/browser/ui/search/instant_controller.h

Issue 14232007: InstantExtended: don't preload the local NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_controller.h
diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h
index fa3cd642c42c497b975666a945b35f49b2bd5879..445c80e8356c1981d8ac5443639c067cd0532c78 100644
--- a/chrome/browser/ui/search/instant_controller.h
+++ b/chrome/browser/ui/search/instant_controller.h
@@ -154,10 +154,10 @@ class InstantController : public InstantPage::Delegate,
// The user is about to switch tabs. Commit the overlay if needed.
void TabDeactivated(content::WebContents* contents);
- // Sets whether Instant should show result overlays. |use_local_overlay_only|
- // will force the use of kLocalOmniboxPopupURL as the Instant URL and is only
+ // Sets whether Instant should show result overlays. |use_local_page_only|
+ // will force the use of baked-in page as the Instant URL and is only
// applicable if |extended_enabled_| is true.
- void SetInstantEnabled(bool instant_enabled, bool use_local_overlay_only);
+ void SetInstantEnabled(bool instant_enabled, bool use_local_page_only);
// The theme has changed. Pass the message to the overlay page.
void ThemeChanged(const ThemeBackgroundInfo& theme_info);
@@ -223,7 +223,7 @@ class InstantController : public InstantPage::Delegate,
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ValidatesSuggestions);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
OmniboxCommitsWhenShownFullHeight);
- FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, LocalNTPIsNotLocalOverlay);
+ FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, LocalNTPIsNotPreloaded);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedManualTest,
MANUAL_OmniboxFocusLoadsInstant);
@@ -377,7 +377,7 @@ class InstantController : public InstantPage::Delegate,
bool instant_enabled_;
// If true, the Instant URL is set to kLocalOmniboxPopupURL.
- bool use_local_overlay_only_;
+ bool use_local_page_only_;
// The state of the overlay page, i.e., the page owned by |overlay_|. Ignored
// if |instant_tab_| is in use.
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_controller.cc » ('j') | chrome/browser/ui/search/instant_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698