Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: media/filters/decrypting_demuxer_stream.cc

Issue 1423163004: media: Replace DecryptorReadyCB with CdmReadyCB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/decrypting_demuxer_stream.h ('k') | media/filters/decrypting_demuxer_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decrypting_demuxer_stream.cc
diff --git a/media/filters/decrypting_demuxer_stream.cc b/media/filters/decrypting_demuxer_stream.cc
index 3e67a29c001483910762f7532f4c9d7ce9ac1454..2189545f784ecd1b4c0df45214abde094f9dc382 100644
--- a/media/filters/decrypting_demuxer_stream.cc
+++ b/media/filters/decrypting_demuxer_stream.cc
@@ -28,18 +28,17 @@ static bool IsStreamValidAndEncrypted(DemuxerStream* stream) {
DecryptingDemuxerStream::DecryptingDemuxerStream(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
const scoped_refptr<MediaLog>& media_log,
- const SetDecryptorReadyCB& set_decryptor_ready_cb,
+ const SetCdmReadyCB& set_cdm_ready_cb,
const base::Closure& waiting_for_decryption_key_cb)
: task_runner_(task_runner),
media_log_(media_log),
state_(kUninitialized),
waiting_for_decryption_key_cb_(waiting_for_decryption_key_cb),
demuxer_stream_(NULL),
- set_decryptor_ready_cb_(set_decryptor_ready_cb),
+ set_cdm_ready_cb_(set_cdm_ready_cb),
decryptor_(NULL),
key_added_while_decrypt_pending_(false),
- weak_factory_(this) {
-}
+ weak_factory_(this) {}
std::string DecryptingDemuxerStream::GetDisplayName() const {
return "DecryptingDemuxerStream";
@@ -59,8 +58,8 @@ void DecryptingDemuxerStream::Initialize(DemuxerStream* stream,
InitializeDecoderConfig();
state_ = kDecryptorRequested;
- set_decryptor_ready_cb_.Run(BindToCurrentLoop(
- base::Bind(&DecryptingDemuxerStream::SetDecryptor, weak_this_)));
+ set_cdm_ready_cb_.Run(BindToCurrentLoop(
+ base::Bind(&DecryptingDemuxerStream::SetCdm, weak_this_)));
}
void DecryptingDemuxerStream::Read(const ReadCB& read_cb) {
@@ -88,7 +87,7 @@ void DecryptingDemuxerStream::Reset(const base::Closure& closure) {
// condition and clean up related tests.
if (state_ == kDecryptorRequested) {
DCHECK(!init_cb_.is_null());
- set_decryptor_ready_cb_.Run(DecryptorReadyCB());
+ set_cdm_ready_cb_.Run(CdmReadyCB());
base::ResetAndReturn(&init_cb_).Run(PIPELINE_ERROR_ABORT);
DoReset();
return;
@@ -160,8 +159,8 @@ DecryptingDemuxerStream::~DecryptingDemuxerStream() {
decryptor_->CancelDecrypt(GetDecryptorStreamType());
decryptor_ = NULL;
}
- if (!set_decryptor_ready_cb_.is_null())
- base::ResetAndReturn(&set_decryptor_ready_cb_).Run(DecryptorReadyCB());
+ if (!set_cdm_ready_cb_.is_null())
+ base::ResetAndReturn(&set_cdm_ready_cb_).Run(CdmReadyCB());
if (!init_cb_.is_null())
base::ResetAndReturn(&init_cb_).Run(PIPELINE_ERROR_ABORT);
if (!read_cb_.is_null())
@@ -171,26 +170,25 @@ DecryptingDemuxerStream::~DecryptingDemuxerStream() {
pending_buffer_to_decrypt_ = NULL;
}
-void DecryptingDemuxerStream::SetDecryptor(
- Decryptor* decryptor,
- const DecryptorAttachedCB& decryptor_attached_cb) {
+void DecryptingDemuxerStream::SetCdm(CdmContext* cdm_context,
+ const CdmAttachedCB& cdm_attached_cb) {
DVLOG(2) << __FUNCTION__;
DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK_EQ(state_, kDecryptorRequested) << state_;
DCHECK(!init_cb_.is_null());
- DCHECK(!set_decryptor_ready_cb_.is_null());
+ DCHECK(!set_cdm_ready_cb_.is_null());
- set_decryptor_ready_cb_.Reset();
+ set_cdm_ready_cb_.Reset();
- if (!decryptor) {
+ if (!cdm_context || !cdm_context->GetDecryptor()) {
MEDIA_LOG(DEBUG, media_log_) << GetDisplayName() << ": decryptor not set";
state_ = kUninitialized;
base::ResetAndReturn(&init_cb_).Run(DECODER_ERROR_NOT_SUPPORTED);
- decryptor_attached_cb.Run(false);
+ cdm_attached_cb.Run(false);
return;
}
- decryptor_ = decryptor;
+ decryptor_ = cdm_context->GetDecryptor();
decryptor_->RegisterNewKeyCB(
GetDecryptorStreamType(),
@@ -199,7 +197,7 @@ void DecryptingDemuxerStream::SetDecryptor(
state_ = kIdle;
base::ResetAndReturn(&init_cb_).Run(PIPELINE_OK);
- decryptor_attached_cb.Run(true);
+ cdm_attached_cb.Run(true);
}
void DecryptingDemuxerStream::DecryptBuffer(
« no previous file with comments | « media/filters/decrypting_demuxer_stream.h ('k') | media/filters/decrypting_demuxer_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698