Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 14230012: Add placeholder git hooks (Closed)

Created:
7 years, 8 months ago by szager1
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Add placeholder git hooks. This is a bit of future-proofing. The git hooks in depot_tools/git-templates/hooks all try to forward to build/git-hooks. Currently, the only actual hook we have is in src/build/git-hooks/pre-commit, which (usefully) makes sure no one inadvertently commits a submodule change. If we want to add more git hooks, we can simply commit them to build/git-hooks, rather than asking everyone to modify .git/hooks in their checkout. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195336

Patch Set 1 #

Total comments: 2

Patch Set 2 : MA's fixes #

Total comments: 2

Patch Set 3 : Fix THIS_FILE_PATH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gclient_scm.py View 1 2 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
szager1
7 years, 8 months ago (2013-04-16 20:41:54 UTC) #1
szager1
Should probably land this first: https://codereview.chromium.org/14139020
7 years, 8 months ago (2013-04-16 20:46:53 UTC) #2
M-A Ruel
https://codereview.chromium.org/14230012/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/14230012/diff/1/gclient_scm.py#newcode655 gclient_scm.py:655: template_path = os.path.join(os.path.dirname(__file__), 'git-templates') Make this a global ALL_CAPS ...
7 years, 8 months ago (2013-04-16 20:52:36 UTC) #3
szager1
https://codereview.chromium.org/14230012/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/14230012/diff/1/gclient_scm.py#newcode655 gclient_scm.py:655: template_path = os.path.join(os.path.dirname(__file__), 'git-templates') On 2013/04/16 20:52:37, Marc-Antoine Ruel ...
7 years, 8 months ago (2013-04-16 21:01:25 UTC) #4
M-A Ruel
https://codereview.chromium.org/14230012/diff/6001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/14230012/diff/6001/gclient_scm.py#newcode19 gclient_scm.py:19: THIS_FILE_PATH = __file__ THIS_FILE_PATH = os.path.abspath(__file__) because it is ...
7 years, 8 months ago (2013-04-19 19:28:58 UTC) #5
szager
https://codereview.chromium.org/14230012/diff/6001/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/14230012/diff/6001/gclient_scm.py#newcode19 gclient_scm.py:19: THIS_FILE_PATH = __file__ On 2013/04/19 19:28:58, Marc-Antoine Ruel wrote: ...
7 years, 8 months ago (2013-04-19 20:12:13 UTC) #6
M-A Ruel
lgtm It'd be nice if it were documented somewhere in the (incredibly outdated) gclient doc. ...
7 years, 8 months ago (2013-04-19 20:14:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/14230012/10001
7 years, 8 months ago (2013-04-19 23:26:58 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 23:30:17 UTC) #9
Message was sent while issue was closed.
Change committed as 195336

Powered by Google App Engine
This is Rietveld 408576698